From a778d373f1e07ace535ceca1118b4741a6a2553d Mon Sep 17 00:00:00 2001 From: Kenneth Moreland Date: Mon, 13 Jun 2016 08:56:40 -0600 Subject: [PATCH] Loosen threshold on test of parametric coordinates The UnitTestParametricCoordinates test uses a pseudorandom number generator to create some random set of parametric coordinates, convert to world coordinates, and then back to parametric coordinates. This has been working fine except that the world coordinate to parametric coordinate conversion is not extremely precise for some cell shapes. (It would not be cost effective to make it more precise.) Because of this, the test_equal for this comparison has a pretty high threshold. While looking at a dashboard I happened across a failure for this test. It turns out that one of the parametric coordinates created for the pyramid test for seed 1465529014 was just outside of this threshold, but otherwise correct. I raised the threshold a little to try to prevent this error. --- vtkm/exec/testing/UnitTestParametricCoordinates.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vtkm/exec/testing/UnitTestParametricCoordinates.cxx b/vtkm/exec/testing/UnitTestParametricCoordinates.cxx index 81ff68edf..41db6e0d2 100644 --- a/vtkm/exec/testing/UnitTestParametricCoordinates.cxx +++ b/vtkm/exec/testing/UnitTestParametricCoordinates.cxx @@ -196,7 +196,7 @@ void TestPCoordsSample(const PointWCoordsType &pointWCoords, workletProxy); VTKM_TEST_ASSERT(!errorMessage.IsErrorRaised(), messageBuffer); - VTKM_TEST_ASSERT(test_equal(pcoords, computedPCoords, 0.01), + VTKM_TEST_ASSERT(test_equal(pcoords, computedPCoords, 0.05), "pcoord/wcoord transform not symmetrical"); } }