From e3e1a76072108d7f42fa8ebc9a41117ce7ecc6eb Mon Sep 17 00:00:00 2001 From: Kenneth Moreland Date: Mon, 26 Apr 2021 12:13:13 -0600 Subject: [PATCH] Disable deprecation for MSVC 2017 Although technically supported, this version of the visual studio likes to put the warnings where templates are defined (rather than instantiated). That makes it impossible to suppress a warning when, for example, when a deprecated class is legitmately used in an std template to implement other deprecated functionality. To prevent this, disable deprecations on MSVC compilers before 2019. I doubt any developers are using this compiler anywhere but the dashboard, and the warnings should legitimately appear elsewhere. --- vtkm/Deprecated.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vtkm/Deprecated.h b/vtkm/Deprecated.h index 68baf1b61..687e2fbcd 100644 --- a/vtkm/Deprecated.h +++ b/vtkm/Deprecated.h @@ -84,7 +84,7 @@ #define VTK_M_DEPRECATED_ATTRIBUTE_SUPPORTED #endif // __has_cpp_attribute(deprecated) -#elif defined(VTKM_MSVC) && (_MSC_VER >= 1900) +#elif defined(VTKM_MSVC) && (_MSC_VER >= 1920) #define VTK_M_DEPRECATED_ATTRIBUTE_SUPPORTED