From 091b246bb0111357edbb9703ea342a944b04deb6 Mon Sep 17 00:00:00 2001 From: Yves Senn Date: Thu, 24 Jul 2014 16:38:41 +0200 Subject: [PATCH] fix, mysql `db:purge` respects `Rails.env`. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously this method always established a connection to the test database. This resulted in buggy behavior when combined with other tasks like `bin/rake db:schema:load`. This was one of the reasons why #15394 (22e9a91189af2c4e6217a888e77f22a23d3247d1) was reverted: > I’ve replicated it on a new app by the following commands: 1) rails generate model post:title, 2) rake db:migrate, 3) rake db:schema:load, 4) rails runner ‘puts Post.first’. The last command goes boom. Problem is that rake db:schema:load wipes the database, and then doesn’t actually restore it. This is all on MySQL. There’s no problem with SQLite. -- DHH https://github.com/rails/rails/commit/22e9a91189af2c4e6217a888e77f22a23d3247d1#commitcomment-6834245 --- activerecord/CHANGELOG.md | 4 ++++ activerecord/lib/active_record/tasks/mysql_database_tasks.rb | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index e3be1eb894..089f93db45 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,7 @@ +* `db:purge` with MySQL respects `Rails.env`. + + *Yves Senn* + * `change_column_default :table, :column, nil` with PostgreSQL will issue a `DROP DEFAULT` instead of a `DEFAULT NULL` query. diff --git a/activerecord/lib/active_record/tasks/mysql_database_tasks.rb b/activerecord/lib/active_record/tasks/mysql_database_tasks.rb index 644c4852b9..d890196f47 100644 --- a/activerecord/lib/active_record/tasks/mysql_database_tasks.rb +++ b/activerecord/lib/active_record/tasks/mysql_database_tasks.rb @@ -42,7 +42,7 @@ def drop end def purge - establish_connection :test + establish_connection configuration connection.recreate_database configuration['database'], creation_options end