From 63970d9b012ec2e480c0c0e0e2f12b641a1ba728 Mon Sep 17 00:00:00 2001 From: Ryo H <49798519+ryobs@users.noreply.github.com> Date: Thu, 28 Mar 2024 21:51:23 +0900 Subject: [PATCH] Fixed typo in guides/README.md --- guides/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/guides/README.md b/guides/README.md index 8aa2b745b9..b1c06301d4 100644 --- a/guides/README.md +++ b/guides/README.md @@ -2,9 +2,9 @@ ## About the Project -The Rails Guides Visual Refresh occured in Q1 2024, and was intended to bring the visual style of the guides inline with the rubyonrails.org site. +The Rails Guides Visual Refresh occurred in Q1 2024, and was intended to bring the visual style of the guides inline with the rubyonrails.org site. -## Editing Depedencies +## Editing Dependencies The editing files for the Guides rebuild reside in `stylesrc` and use SCSS to improve developer experience. The code base relies on `include_media` (https://eduardoboucas.github.io/include-media/) to enable inline media-queries adjustments. We've also relied on the standard `normalize.css` (https://necolas.github.io/normalize.css/) to help bring all browsers together. @@ -16,12 +16,12 @@ To generate new guides into static files, type `rake guides:generate` from insid ### Why are you not using CSS variables? -Per the MDN documentation on CSS custom properties (https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties), they are not supported in media or container queries at this point (Feb 2024). They may in future releases, and we should pivot to that when they are more wholistically supported. SCSS variables, because they are interpolated at build, serve a similar purpose and allow us the flexibilty to support much older browsers. +Per the MDN documentation on CSS custom properties (https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties), they are not supported in media or container queries at this point (Feb 2024). They may in future releases, and we should pivot to that when they are more wholistically supported. SCSS variables, because they are interpolated at build, serve a similar purpose and allow us the flexibility to support much older browsers. ### Why do we include LTR and RTL? LTR/RTL (Left to right/right to left) is a layout change based on the nature of the language the site is being displayed in. Arabic and Farsi are two well known "RTL" languages. If the site is automatically translated, then the layout will adjust (mirror horizontally) to be more in line with the text. -### Why is Dark Mode in a seperate file +### Why is Dark Mode in a separate file IncludeMedia does not handle `prefers-color-scheme` at this time, so it was extracted. \ No newline at end of file