From abe0b123bc7a27bcf27b5479be5193e67a749ee0 Mon Sep 17 00:00:00 2001 From: Adrianna Chang Date: Tue, 2 May 2023 09:15:01 -0400 Subject: [PATCH] Remove `AbstractMysqlAdapterTest` This test was added in 8f5095a to ensure that there was coverage for `AbstractMysqlAdapter#execute`, but 63c0d6b refactored `#execute` to be defined at the Abstract adapter level, and rely on concrete MySQL adapters to implement `#raw_execute`. This test won't pass without having the `ExampleMysqlAdapter` implement `#raw_execute`, but this test is obsolete now that AbstractMysql2Adapter doesn't implement `#execute` directly. --- .../adapters/abstract_mysql_adapter_test.rb | 24 ------------------- 1 file changed, 24 deletions(-) delete mode 100644 activerecord/test/cases/adapters/abstract_mysql_adapter_test.rb diff --git a/activerecord/test/cases/adapters/abstract_mysql_adapter_test.rb b/activerecord/test/cases/adapters/abstract_mysql_adapter_test.rb deleted file mode 100644 index ac50a89c37..0000000000 --- a/activerecord/test/cases/adapters/abstract_mysql_adapter_test.rb +++ /dev/null @@ -1,24 +0,0 @@ -# frozen_string_literal: true - -require "cases/helper" - -class AbstractMysqlAdapterTest < ActiveRecord::Mysql2TestCase - if current_adapter?(:Mysql2Adapter) - class ExampleMysqlAdapter < ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter; end - - def setup - @conn = ExampleMysqlAdapter.new( - ActiveRecord::ConnectionAdapters::Mysql2Adapter.new_client({}), - ActiveRecord::Base.logger, - nil, - { socket: File::NULL } - ) - end - - def test_execute_not_raising_error - assert_nothing_raised do - @conn.execute("SELECT 1") - end - end - end -end