From e7eb70c71342c8ca2ac349c7e5fccdb29776cd8a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rafael=20Mendon=C3=A7a=20Fran=C3=A7a?=
 <rafael@rubyonrails.org>
Date: Mon, 15 Apr 2024 18:19:04 +0000
Subject: [PATCH] Run devcontainer smoke tests in one single job

GitHub Actions spams the commit status with one for each job.

We want to keep the number of statuses to a minimum, so we can see the
main buildkite status, so we should run all the tests in a single job.
---
 .github/workflows/devcontainer-smoke-test.yml | 72 +++++++++++++++----
 1 file changed, 60 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/devcontainer-smoke-test.yml b/.github/workflows/devcontainer-smoke-test.yml
index 76711e7c39..38d5f959cc 100644
--- a/.github/workflows/devcontainer-smoke-test.yml
+++ b/.github/workflows/devcontainer-smoke-test.yml
@@ -12,12 +12,6 @@ jobs:
       packages: write
     strategy:
       fail-fast: false
-      matrix:
-        DATABASE:
-          - sqlite3
-          - postgresql
-          - mysql
-          - trilogy
 
     steps:
       - name: Checkout (GitHub)
@@ -36,16 +30,70 @@ jobs:
           ruby-version: 3.3
           bundler-cache: true
 
-      - name: Generate rails app
-        run: bundle exec railties/exe/rails new myapp --database="${{ matrix.DATABASE }}" --dev
+      - name: Generate rails app sqlite3
+        run: bundle exec railties/exe/rails new myapp_sqlite --database="sqlite3" --dev
 
-      - name: Test devcontainer
+      - name: Test devcontainer sqlite3
         uses: devcontainers/ci@v0.3
         with:
-          subFolder: myapp
+          subFolder: myapp_sqlite
           imageName: ghcr.io/rails/smoke-test-devcontainer
           cacheFrom: ghcr.io/rails/smoke-test-devcontainer
-          imageTag: ${{ matrix.DATABASE }}
+          imageTag: sqlite3
           push: ${{ github.repository_owner == 'rails' && 'filter' || 'never' }}
           refFilterForPush: refs/heads/main
-          runCmd: bin/rails g scaffold Post && bin/rails db:migrate && bin/rails test
\ No newline at end of file
+          runCmd: bin/rails g scaffold Post && bin/rails db:migrate && bin/rails test
+
+      - name: Stop all containers
+        run: docker ps -q | xargs docker stop
+
+      - name: Generate rails app postgresql
+        run: bundle exec railties/exe/rails new myapp_postgresql --database="postgresql" --dev
+
+      - name: Test devcontainer postgresql
+        uses: devcontainers/ci@v0.3
+        with:
+          subFolder: myapp_postgresql
+          imageName: ghcr.io/rails/smoke-test-devcontainer
+          cacheFrom: ghcr.io/rails/smoke-test-devcontainer
+          imageTag: postgresql
+          push: ${{ github.repository_owner == 'rails' && 'filter' || 'never' }}
+          refFilterForPush: refs/heads/main
+          runCmd: bin/rails g scaffold Post && bin/rails db:migrate && bin/rails test
+
+      - name: Stop all containers
+        run: docker ps -q | xargs docker stop
+
+      - name: Generate rails app mysql
+        run: bundle exec railties/exe/rails new myapp_mysql --database="mysql" --dev
+
+      - name: Test devcontainer mysql
+        uses: devcontainers/ci@v0.3
+        with:
+          subFolder: myapp_mysql
+          imageName: ghcr.io/rails/smoke-test-devcontainer
+          cacheFrom: ghcr.io/rails/smoke-test-devcontainer
+          imageTag: mysql
+          push: ${{ github.repository_owner == 'rails' && 'filter' || 'never' }}
+          refFilterForPush: refs/heads/main
+          runCmd: bin/rails g scaffold Post && bin/rails db:migrate && bin/rails test
+
+      - name: Stop all containers
+        run: docker ps -q | xargs docker stop
+
+      - name: Generate rails app trilogy
+        run: bundle exec railties/exe/rails new myapp_trilogy --database="trilogy" --dev
+
+      - name: Test devcontainer trilogy
+        uses: devcontainers/ci@v0.3
+        with:
+          subFolder: myapp_trilogy
+          imageName: ghcr.io/rails/smoke-test-devcontainer
+          cacheFrom: ghcr.io/rails/smoke-test-devcontainer
+          imageTag: trilogy
+          push: ${{ github.repository_owner == 'rails' && 'filter' || 'never' }}
+          refFilterForPush: refs/heads/main
+          runCmd: bin/rails g scaffold Post && bin/rails db:migrate && bin/rails test
+
+      - name: Stop all containers
+        run: docker ps -q | xargs docker stop