From 28d77f9354de9c916921b36be4edc433b86fe29d Mon Sep 17 00:00:00 2001 From: Jeroen Bakker Date: Fri, 19 Jun 2020 08:17:07 +0200 Subject: [PATCH] Performance: Never draw channels region during playback Channels aren't visually changed by playing back an animation so there is no need to do this. As rendering channels is using a lot of logic (filtering animation data, converting fcurves to samples etc) it has an noticeable overhead. This change has no functional limitation. Users are still able to do everything during animation playback. There are other mechanisms in place that take care of that. Spring 02_020_A.anim.blend went from 11.8 to 12.0 on a Ryzen 1700. I didn't test with scenes but it should be more noticeable with more complex scenes. Reviewed By: Brecht van Lommel Differential Revision: https://developer.blender.org/D8073 --- source/blender/editors/screen/screen_ops.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/source/blender/editors/screen/screen_ops.c b/source/blender/editors/screen/screen_ops.c index d6b8ebddfee..1d03b277549 100644 --- a/source/blender/editors/screen/screen_ops.c +++ b/source/blender/editors/screen/screen_ops.c @@ -4329,19 +4329,6 @@ static bool match_region_with_redraws(eSpace_Type spacetype, break; } } - else if (regiontype == RGN_TYPE_CHANNELS) { - switch (spacetype) { - case SPACE_GRAPH: - case SPACE_ACTION: - case SPACE_NLA: - if (redraws & TIME_ALL_ANIM_WIN) { - return true; - } - break; - default: - break; - } - } else if (regiontype == RGN_TYPE_UI) { if (spacetype == SPACE_CLIP) { /* Track Preview button is on Properties Editor in SpaceClip,