From dc243ff06b9d9f812b183b58d80bd1648399d88e Mon Sep 17 00:00:00 2001 From: Jeroen Bakker Date: Thu, 28 Mar 2024 11:47:21 +0100 Subject: [PATCH] Fix: EEVEE-Next: Crash division by zero When no shadow views are needed Blender could signal a division by zero. This change fixes this by safe guarding the division by zero ensuring the there is always a view to update. --- source/blender/draw/engines/eevee_next/eevee_shadow.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/blender/draw/engines/eevee_next/eevee_shadow.cc b/source/blender/draw/engines/eevee_next/eevee_shadow.cc index ebe053818cf..b8007580a57 100644 --- a/source/blender/draw/engines/eevee_next/eevee_shadow.cc +++ b/source/blender/draw/engines/eevee_next/eevee_shadow.cc @@ -1333,7 +1333,7 @@ int ShadowModule::max_view_per_tilemap() potential_view_count += 1; } } - int max_view_count = divide_ceil_u(SHADOW_VIEW_MAX, potential_view_count); + int max_view_count = divide_ceil_u(SHADOW_VIEW_MAX, math::max(potential_view_count, 1)); /* For viewport interactivity, have a hard maximum. This allows smoother experience. */ if (inst_.is_transforming() || inst_.is_navigating()) { max_view_count = math::min(2, max_view_count);