From e4c299d9753d5493719a7e21fc9d23371e6f14ef Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Tue, 27 Sep 2011 12:08:35 +0000 Subject: [PATCH] comment warnings as errors for MSVC - it too easily made small problems like unused vars into errors which gets annoying for non developers. with GCC we have *some* warnings as errors which works out better. --- intern/ghost/CMakeLists.txt | 7 ++++--- source/blender/blenkernel/CMakeLists.txt | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/intern/ghost/CMakeLists.txt b/intern/ghost/CMakeLists.txt index bdda0f3382e..e028c4e6912 100644 --- a/intern/ghost/CMakeLists.txt +++ b/intern/ghost/CMakeLists.txt @@ -248,9 +248,10 @@ elseif(UNIX) endif() elseif(WIN32) - if(MSVC) - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /WX") - endif() + ## Warnings as errors, this is too strict! + #if(MSVC) + # set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /WX") + #endif() list(APPEND INC_SYS ${WINTAB_INC} diff --git a/source/blender/blenkernel/CMakeLists.txt b/source/blender/blenkernel/CMakeLists.txt index 93ab29c5f49..91749143008 100644 --- a/source/blender/blenkernel/CMakeLists.txt +++ b/source/blender/blenkernel/CMakeLists.txt @@ -361,8 +361,9 @@ if(WITH_GAMEENGINE) ) endif() -if(MSVC) - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /WX") -endif() +## Warnings as errors, this is too strict! +#if(MSVC) +# set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /WX") +#endif() blender_add_lib(bf_blenkernel "${SRC}" "${INC}" "${INC_SYS}")