From 819767ea1a4c3936d1489efb6a30e5be9343bd8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Mon, 11 Sep 2023 17:22:18 +0200 Subject: [PATCH] Webapp: tweak the .editorconfig and .prettierrc files + re-format Try to get the `.editorconfig` and `.prettierrc` files as close as possible to the formatting that was used in Flamenco. Because these files weren't here during most of Flamenco's development so far, having them caused quite a few changes in the webapp files. No functional changes intended. --- .editorconfig | 1 + .prettierrc | 3 +- web/app/index.html | 6 +- web/app/src/App.vue | 36 +- web/app/src/SetupAssistant.vue | 19 +- web/app/src/api-client.js | 6 +- web/app/src/autoreloader.js | 16 +- web/app/src/clipboard.js | 12 +- web/app/src/components/ApiSpinner.vue | 4 +- web/app/src/components/ConnectionStatus.vue | 4 +- web/app/src/components/GetTheAddon.vue | 10 +- web/app/src/components/LinkWorker.vue | 4 +- web/app/src/components/LinkWorkerTask.vue | 9 +- .../components/PopoverEditableJobPriority.vue | 17 +- web/app/src/components/StatusFilterBar.vue | 18 +- web/app/src/components/SwitchCheckbox.vue | 14 +- web/app/src/components/TabItem.vue | 8 +- web/app/src/components/TabsWrapper.vue | 13 +- web/app/src/components/UpdateListener.vue | 132 +++---- web/app/src/components/footer/FooterPopup.vue | 39 +- .../src/components/footer/NotificationBar.vue | 6 +- .../components/footer/NotificationList.vue | 35 +- web/app/src/components/footer/TaskLog.vue | 32 +- web/app/src/components/jobs/Blocklist.vue | 47 ++- web/app/src/components/jobs/JobActionsBar.vue | 75 ++-- web/app/src/components/jobs/JobDetails.vue | 59 +-- web/app/src/components/jobs/JobsTable.vue | 73 ++-- .../src/components/jobs/LastRenderedImage.vue | 45 +-- .../src/components/jobs/TaskActionsBar.vue | 25 +- web/app/src/components/jobs/TaskDetails.vue | 37 +- web/app/src/components/jobs/TasksTable.vue | 80 +++-- web/app/src/components/steps/StepItem.vue | 18 +- .../components/workers/WorkerActionsBar.vue | 21 +- .../src/components/workers/WorkerDetails.vue | 142 +++++--- .../src/components/workers/WorkersTable.vue | 51 +-- web/app/src/datetime.js | 12 +- web/app/src/main.js | 47 +-- web/app/src/router/index.js | 6 +- web/app/src/router/setup-assistant.js | 12 +- web/app/src/setup-assistant.js | 20 +- web/app/src/statusindicator.js | 6 +- web/app/src/stores/api-query-count.js | 38 +- web/app/src/stores/jobs.js | 35 +- web/app/src/stores/notifications.js | 30 +- web/app/src/stores/socket-status.js | 22 +- web/app/src/stores/tasklog.js | 15 +- web/app/src/stores/tasks.js | 31 +- web/app/src/stores/workers.js | 8 +- web/app/src/urls.js | 9 +- web/app/src/views/JobsView.vue | 134 ++++--- web/app/src/views/LastRenderedView.vue | 28 +- web/app/src/views/SetupAssistantView.vue | 336 +++++++++++------- web/app/src/views/TagsView.vue | 81 ++--- web/app/src/views/WorkersView.vue | 47 +-- web/app/vite.config.js | 12 +- 55 files changed, 1132 insertions(+), 914 deletions(-) diff --git a/.editorconfig b/.editorconfig index 48252e96..234fe79b 100644 --- a/.editorconfig +++ b/.editorconfig @@ -8,6 +8,7 @@ insert_final_newline = true trim_trailing_whitespace = true indent_style = space indent_size = 2 +max_line_length = 100 [*.go] indent_style = tab diff --git a/.prettierrc b/.prettierrc index 2c126df5..619d9a1e 100644 --- a/.prettierrc +++ b/.prettierrc @@ -3,6 +3,7 @@ "useTabs": false, "singleQuote": true, "semi": true, - "bracketSpacing": false, + "bracketSpacing": true, + "bracketSameLine": true, "arrowParens": "always" } diff --git a/web/app/index.html b/web/app/index.html index e6959f31..46c96dd5 100644 --- a/web/app/index.html +++ b/web/app/index.html @@ -2,9 +2,9 @@ - - - + + + Flamenco Manager diff --git a/web/app/src/App.vue b/web/app/src/App.vue index 269709ff..3e9327ce 100644 --- a/web/app/src/App.vue +++ b/web/app/src/App.vue @@ -20,8 +20,7 @@ add-on - | API - | version: {{ flamencoVersion }} + | API | version: {{ flamencoVersion }} @@ -29,14 +28,14 @@ diff --git a/web/app/src/SetupAssistant.vue b/web/app/src/SetupAssistant.vue index 95d74f2e..1ecfbb14 100644 --- a/web/app/src/SetupAssistant.vue +++ b/web/app/src/SetupAssistant.vue @@ -12,12 +12,11 @@ diff --git a/web/app/src/api-client.js b/web/app/src/api-client.js index 4d8742de..6e510936 100644 --- a/web/app/src/api-client.js +++ b/web/app/src/api-client.js @@ -1,6 +1,6 @@ -import { ApiClient } from "@/manager-api"; -import { CountingApiClient } from "@/stores/api-query-count"; -import { api as apiURL } from '@/urls' +import { ApiClient } from '@/manager-api'; +import { CountingApiClient } from '@/stores/api-query-count'; +import { api as apiURL } from '@/urls'; /** * Scrub the custom User-Agent header from the API client, for those webbrowsers diff --git a/web/app/src/autoreloader.js b/web/app/src/autoreloader.js index 9282891a..7c68c683 100644 --- a/web/app/src/autoreloader.js +++ b/web/app/src/autoreloader.js @@ -1,9 +1,9 @@ -import { DateTime } from "luxon"; +import { DateTime } from 'luxon'; // Do a full refresh once per hour. This is just to make sure that long-lived // displays (like the TV in the hallway at Blender HQ) pick up on HTML/JS/CSS // changes eventually. -const reloadAfter = {minute: 60}; +const reloadAfter = { minute: 60 }; function getReloadDeadline() { return DateTime.now().plus(reloadAfter); @@ -27,10 +27,10 @@ export default function autoreload() { // Check whether reloading is needed every minute. window.setInterval(maybeReload, 60 * 1000); - window.addEventListener("resize", deferReload); - window.addEventListener("mousedown", deferReload); - window.addEventListener("mouseup", deferReload); - window.addEventListener("mousemove", deferReload); - window.addEventListener("keydown", deferReload); - window.addEventListener("keyup", deferReload); + window.addEventListener('resize', deferReload); + window.addEventListener('mousedown', deferReload); + window.addEventListener('mouseup', deferReload); + window.addEventListener('mousemove', deferReload); + window.addEventListener('keydown', deferReload); + window.addEventListener('keyup', deferReload); } diff --git a/web/app/src/clipboard.js b/web/app/src/clipboard.js index 6ce430eb..8110996d 100644 --- a/web/app/src/clipboard.js +++ b/web/app/src/clipboard.js @@ -1,4 +1,3 @@ - /** * The duration in milliseconds of the "flash" effect, when an element has been * copied. @@ -7,7 +6,6 @@ */ const flashAfterCopyDuration = 150; - /** * Copy the inner text of an element to the clipboard. * @@ -30,9 +28,9 @@ export function copyElementData(clickEvent) { } function copyElementValue(sourceElement, value) { - const inputElement = document.createElement("input"); + const inputElement = document.createElement('input'); document.body.appendChild(inputElement); - inputElement.setAttribute("value", value); + inputElement.setAttribute('value', value); inputElement.select(); // Note that the `navigator.clipboard` interface is only available when using @@ -40,15 +38,15 @@ function copyElementValue(sourceElement, value) { // This is why this code falls back to the deprecated `document.execCommand()` // call. // Source: https://developer.mozilla.org/en-US/docs/Web/API/Clipboard - document.execCommand("copy"); + document.execCommand('copy'); document.body.removeChild(inputElement); flashElement(sourceElement); } function flashElement(element) { - element.classList.add("copied"); + element.classList.add('copied'); window.setTimeout(() => { - element.classList.remove("copied"); + element.classList.remove('copied'); }, 150); } diff --git a/web/app/src/components/ApiSpinner.vue b/web/app/src/components/ApiSpinner.vue index ec622acb..ff98436e 100644 --- a/web/app/src/components/ApiSpinner.vue +++ b/web/app/src/components/ApiSpinner.vue @@ -29,7 +29,7 @@ span { .spinner { -webkit-animation: rotate 2s linear infinite; - animation: rotate 2s linear infinite; + animation: rotate 2s linear infinite; z-index: 2; position: absolute; top: 50%; @@ -42,7 +42,7 @@ span { stroke: var(--color-text-hint); stroke-linecap: round; -webkit-animation: dash 1.5s ease-in-out infinite; - animation: dash 1.5s ease-in-out infinite; + animation: dash 1.5s ease-in-out infinite; } @-webkit-keyframes rotate { diff --git a/web/app/src/components/ConnectionStatus.vue b/web/app/src/components/ConnectionStatus.vue index c870fc99..0ca587d2 100644 --- a/web/app/src/components/ConnectionStatus.vue +++ b/web/app/src/components/ConnectionStatus.vue @@ -1,5 +1,7 @@ diff --git a/web/app/src/components/LinkWorkerTask.vue b/web/app/src/components/LinkWorkerTask.vue index 32dc43e5..ee82ebcd 100644 --- a/web/app/src/components/LinkWorkerTask.vue +++ b/web/app/src/components/LinkWorkerTask.vue @@ -1,8 +1,13 @@