From c61849417774d7339db31875b7749ffa302a027e Mon Sep 17 00:00:00 2001
From: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
Date: Fri, 20 Aug 2021 09:32:48 +0200
Subject: [PATCH] return early if backendName is empty

Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
---
 pkg/collector/skipper_collector.go | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/pkg/collector/skipper_collector.go b/pkg/collector/skipper_collector.go
index 751ac7b..f360bdf 100644
--- a/pkg/collector/skipper_collector.go
+++ b/pkg/collector/skipper_collector.go
@@ -139,17 +139,17 @@ func getRouteGroupWeight(backends []rgv1.RouteGroupBackendReference, backendName
 		return 1.0, nil
 	}
 
+	if backendName == "" {
+		return 0.0, errBackendNameMissing
+	}
+
 	for _, backend := range backends {
 		if backend.BackendName == backendName {
 			return float64(backend.Weight) / 100.0, nil
 		}
 	}
 
-	if backendName != "" {
-		return 0.0, nil
-	}
-
-	return 0.0, errBackendNameMissing
+	return 0.0, nil
 }
 
 // getCollector returns a collector for getting the metrics.