From cc9279b283f4c0921f9ec63c70aaee135954fb97 Mon Sep 17 00:00:00 2001 From: Anatolii Dutchak Date: Thu, 8 Apr 2021 12:55:17 +0300 Subject: [PATCH] Chnaged error type check from errors.Is() to errors.As() because errors.Is() always returns False Signed-off-by: Anatolii Dutchak --- pkg/provider/hpa.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/provider/hpa.go b/pkg/provider/hpa.go index ad6356a..fbbd248 100644 --- a/pkg/provider/hpa.go +++ b/pkg/provider/hpa.go @@ -161,8 +161,10 @@ func (p *HPAProvider) updateHPAs() error { c, err := p.collectorFactory.NewCollector(&hpa, config, interval) if err != nil { - // Only log when it's not a PluginNotFoundError AND flag disregardIncompatibleHPAs is true - if !(errors.Is(err, &collector.PluginNotFoundError{}) && p.disregardIncompatibleHPAs) { + // Only log when it's not a PluginNotFoundError AND flag disregardIncompatibleHPAs is true + var pluginNotFoundError *collector.PluginNotFoundError + + if !(errors.As(err, &pluginNotFoundError) && p.disregardIncompatibleHPAs) { p.recorder.Eventf(&hpa, apiv1.EventTypeWarning, "CreateNewMetricsCollector", "Failed to create new metrics collector: %v", err) }