From 3f27b6db0f127f9aa10f93a07b8ec8517f3d4a33 Mon Sep 17 00:00:00 2001 From: Chris Mc Date: Sat, 1 Apr 2023 02:45:37 -0700 Subject: [PATCH] (#16759) docs: clarify everything should use CMake 3.15 to match Conan 2.0 --- docs/error_knowledge_base.md | 4 +++- .../autotools_package/all/test_package/CMakeLists.txt | 2 +- .../autotools_package/all/test_v1_package/CMakeLists.txt | 2 +- .../cmake_package/all/test_package/CMakeLists.txt | 2 +- .../cmake_package/all/test_v1_package/CMakeLists.txt | 2 +- .../header_only/all/test_package/CMakeLists.txt | 2 +- .../header_only/all/test_v1_package/CMakeLists.txt | 2 +- .../msbuild_package/all/test_package/CMakeLists.txt | 2 +- .../msbuild_package/all/test_v1_package/CMakeLists.txt | 2 +- 9 files changed, 11 insertions(+), 9 deletions(-) diff --git a/docs/error_knowledge_base.md b/docs/error_knowledge_base.md index f9d83f1247..2cd397492d 100644 --- a/docs/error_knowledge_base.md +++ b/docs/error_knowledge_base.md @@ -311,7 +311,9 @@ The CMake definition [CMAKE_VERBOSE_MAKEFILE](https://cmake.org/cmake/help/lates #### **#KB-H048: "CMAKE VERSION REQUIRED"** -The file test_package/CMakeLists.txt should require CMake 3.1 by default: [cmake_minimum_required(VERSION 3.1)](https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html). The CMake wrapper file can require CMake 2.8, because Conan recipe and the test package are totally separated. However, if [CMAKE_CXX_STANDARD](https://cmake.org/cmake/help/latest/variable/CMAKE_CXX_STANDARD.html) or [CXX_STANDARD](https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD.html#prop_tgt:CXX_STANDARD) is explicit, CMake 3.1 is mandatory. +> **Warning**: This is a legacy Conan 1.x details from the deprecated generators + +The file test_package/CMakeLists.txt should require CMake 3.15 by default: [cmake_minimum_required(VERSION 3.15)](https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html). The CMake wrapper file can require CMake 2.8, because Conan recipe and the test package are totally separated. However, if [CMAKE_CXX_STANDARD](https://cmake.org/cmake/help/latest/variable/CMAKE_CXX_STANDARD.html) or [CXX_STANDARD](https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD.html#prop_tgt:CXX_STANDARD) is explicit, CMake 3.1 is mandatory. #### **#KB-H049: "CMAKE WINDOWS EXPORT ALL SYMBOLS"** diff --git a/docs/package_templates/autotools_package/all/test_package/CMakeLists.txt b/docs/package_templates/autotools_package/all/test_package/CMakeLists.txt index d5f12b4376..006bc198df 100644 --- a/docs/package_templates/autotools_package/all/test_package/CMakeLists.txt +++ b/docs/package_templates/autotools_package/all/test_package/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.1) +cmake_minimum_required(VERSION 3.15) project(test_package LANGUAGES C) # if the project is pure C # project(test_package LANGUAGES CXX) # if the project uses c++ diff --git a/docs/package_templates/autotools_package/all/test_v1_package/CMakeLists.txt b/docs/package_templates/autotools_package/all/test_v1_package/CMakeLists.txt index e4a742eca8..206d47b726 100644 --- a/docs/package_templates/autotools_package/all/test_v1_package/CMakeLists.txt +++ b/docs/package_templates/autotools_package/all/test_v1_package/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.1) +cmake_minimum_required(VERSION 3.15) project(test_package LANGUAGES C) # if the project is pure C # project(test_package LANGUAGES CXX) # if the project uses c++ diff --git a/docs/package_templates/cmake_package/all/test_package/CMakeLists.txt b/docs/package_templates/cmake_package/all/test_package/CMakeLists.txt index bf37e23371..d742678fc6 100644 --- a/docs/package_templates/cmake_package/all/test_package/CMakeLists.txt +++ b/docs/package_templates/cmake_package/all/test_package/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.8) +cmake_minimum_required(VERSION 3.15) project(test_package C) # if the project is pure C # project(test_package CXX) # if the project uses c++ diff --git a/docs/package_templates/cmake_package/all/test_v1_package/CMakeLists.txt b/docs/package_templates/cmake_package/all/test_v1_package/CMakeLists.txt index 925ecbe19e..91630d79f4 100644 --- a/docs/package_templates/cmake_package/all/test_v1_package/CMakeLists.txt +++ b/docs/package_templates/cmake_package/all/test_v1_package/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.1) +cmake_minimum_required(VERSION 3.15) project(test_package) include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake) diff --git a/docs/package_templates/header_only/all/test_package/CMakeLists.txt b/docs/package_templates/header_only/all/test_package/CMakeLists.txt index bf8eccb9b5..eaac388e85 100644 --- a/docs/package_templates/header_only/all/test_package/CMakeLists.txt +++ b/docs/package_templates/header_only/all/test_package/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.8) +cmake_minimum_required(VERSION 3.15) project(test_package LANGUAGES C) # if the project is pure C # project(test_package LANGUAGES CXX) # if the project uses c++ diff --git a/docs/package_templates/header_only/all/test_v1_package/CMakeLists.txt b/docs/package_templates/header_only/all/test_v1_package/CMakeLists.txt index 0aeb3e1d92..7738c036b5 100644 --- a/docs/package_templates/header_only/all/test_v1_package/CMakeLists.txt +++ b/docs/package_templates/header_only/all/test_v1_package/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.8) +cmake_minimum_required(VERSION 3.15) project(test_package LANGUAGES C) # if the project is pure C project(test_package LANGUAGES CXX) # if the project uses c++ diff --git a/docs/package_templates/msbuild_package/all/test_package/CMakeLists.txt b/docs/package_templates/msbuild_package/all/test_package/CMakeLists.txt index b8db27ff53..15b2566757 100644 --- a/docs/package_templates/msbuild_package/all/test_package/CMakeLists.txt +++ b/docs/package_templates/msbuild_package/all/test_package/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.8) +cmake_minimum_required(VERSION 3.15) project(test_package C) # if the project is pure C project(test_package CXX) # if the project uses c++ diff --git a/docs/package_templates/msbuild_package/all/test_v1_package/CMakeLists.txt b/docs/package_templates/msbuild_package/all/test_v1_package/CMakeLists.txt index 983c9e84f7..510461758a 100644 --- a/docs/package_templates/msbuild_package/all/test_v1_package/CMakeLists.txt +++ b/docs/package_templates/msbuild_package/all/test_v1_package/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.8) +cmake_minimum_required(VERSION 3.15) project(test_package C) # if the project is pure C project(test_package CXX) # if the project uses c++