Improve the usage of docker_host configuration #260

2023-06-28T10:18:11Z

Zettat123 commented

2023-06-28 10:18:11 +00:00

(Migrated from gitea.com)

Users could use docker_host configuration to specify which docker daemon will be used by act_runner.

If docker_host is empty, act_runner will find an available docker host automatically.
If docker_host is "-", act_runner will find an available docker host automatically, but the docker host won't be mounted to the job containers and service containers.
If docker_host is not empty or "-", the specified docker host will be used. An error will be returned if it doesn't work.

Follow #242, #244 Fixes #258 Users could use `docker_host` configuration to specify which docker daemon will be used by act_runner. - If `docker_host` is **empty**, act_runner will find an available docker host automatically. - If `docker_host` is **"-"**, act_runner will find an available docker host automatically, but the docker host won't be mounted to the job containers and service containers. - If `docker_host` is **not empty or "-"**, the specified docker host will be used. An error will be returned if it doesn't work.

wolfogre (Migrated from gitea.com) approved these changes 2023-06-30 03:40:09 +00:00

wolfogre (Migrated from gitea.com) left a comment

LGTM, just some a problem about code style.

internal/app/cmd/docker_deamon.go

wolfogre (Migrated from gitea.com) commented

2023-06-30 03:40:09 +00:00

The functions body code smells bad.

Please change it to

if xx {
	return
}
if yy {
	return
}
return

The functions body code smells bad. Please change it to ``` if xx { return } if yy { return } return ```

wolfogre (Migrated from gitea.com) commented

2023-06-30 03:56:38 +00:00

fixed in ba20ddb2f7

fixed in ba20ddb2f7789bfcdd36658dddb17d54419d0a8e

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: hiifong/act_runner#260

Improve the usage of docker_host configuration #260

Improve the usage of `docker_host` configuration #260