From 1038eaa283a5c804e84f5c9ea934a6f30a450011 Mon Sep 17 00:00:00 2001
From: Andreas Dangel <andreas.dangel@pmd-code.org>
Date: Fri, 6 Sep 2024 19:43:07 +0200
Subject: [PATCH] [apex] Verify EmptyIfStmt and EmptyStatementBlock with
 triggers

---
 .../apex/rule/errorprone/xml/EmptyIfStmt.xml  | 25 ++++++++++++++++
 .../errorprone/xml/EmptyStatementBlock.xml    | 29 +++++++++++++++++++
 2 files changed, 54 insertions(+)

diff --git a/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/errorprone/xml/EmptyIfStmt.xml b/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/errorprone/xml/EmptyIfStmt.xml
index 3c55ad6f61..9909227e33 100644
--- a/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/errorprone/xml/EmptyIfStmt.xml
+++ b/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/errorprone/xml/EmptyIfStmt.xml
@@ -30,4 +30,29 @@ public class Foo {
 }
         ]]></code>
     </test-code>
+
+    <test-code>
+        <description>EmptyIfStatement in trigger (#5138)</description>
+        <expected-problems>1</expected-problems>
+        <expected-linenumbers>9</expected-linenumbers>
+        <code><![CDATA[
+// https://github.com/SalesforceLabs/chatter-delete-blocker/blob/master/src/triggers/DisableFeedPostDeletes.trigger
+/**
+ * Author: Marcus Ericsson - mericsson@salesforce.com
+ */
+trigger DisableFeedPostDeletes on FeedItem (before delete)
+{
+    if (!DisableChatterDeleteDelegate.allowDelete()) {
+        for(FeedItem f : Trigger.old){
+            if (((String)f.parentId).startsWith('00Q') && f.type == 'TrackedChange') {
+                // ok to ignore
+            }
+            else {
+                f.addError('Your administrator has disabled feed post and comment deletions.');
+            }
+        }
+    }
+}
+]]></code>
+    </test-code>
 </test-data>
diff --git a/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/errorprone/xml/EmptyStatementBlock.xml b/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/errorprone/xml/EmptyStatementBlock.xml
index b7733e0e0a..30ae0208e4 100644
--- a/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/errorprone/xml/EmptyStatementBlock.xml
+++ b/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/errorprone/xml/EmptyStatementBlock.xml
@@ -143,6 +143,35 @@ public class Foo {
         }
     }
 }
+]]></code>
+    </test-code>
+
+    <test-code>
+        <description>EmptyStatementBlock in trigger (#5138)</description>
+        <expected-problems>1</expected-problems>
+        <expected-linenumbers>18</expected-linenumbers>
+        <code><![CDATA[
+// https://github.com/SalesforceLabs/chatter-delete-blocker/blob/master/src/triggers/DisableFeedPostDeletes.trigger
+/**
+ * Author: Marcus Ericsson - mericsson@salesforce.com
+ */
+trigger DisableFeedPostDeletes on FeedItem (before delete)
+{
+    if (!DisableChatterDeleteDelegate.allowDelete()) {
+        for(FeedItem f : Trigger.old){
+            if (((String)f.parentId).startsWith('00Q') && f.type == 'TrackedChange') {
+                // ok to ignore
+            }
+            else {
+                f.addError('Your administrator has disabled feed post and comment deletions.');
+            }
+        }
+    }
+
+    public void setBar(Integer bar) {
+         // empty
+    }
+}
 ]]></code>
     </test-code>
 </test-data>