From f2ec1be93f0737c5f832b3566f2dbc69b397c83b Mon Sep 17 00:00:00 2001
From: Andreas Dangel <adangel@users.sourceforge.net>
Date: Thu, 19 Nov 2015 21:35:50 +0100
Subject: [PATCH] #1438 UseNotifyAllInsteadOfNotify gives false positive

---
 .../src/main/resources/rulesets/java/design.xml     |  2 +-
 .../rule/design/xml/UseNotifyAllInsteadOfNotify.xml | 13 +++++++++++++
 src/site/markdown/overview/changelog.md             |  2 ++
 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/pmd-java/src/main/resources/rulesets/java/design.xml b/pmd-java/src/main/resources/rulesets/java/design.xml
index feef154908..76f312421b 100644
--- a/pmd-java/src/main/resources/rulesets/java/design.xml
+++ b/pmd-java/src/main/resources/rulesets/java/design.xml
@@ -978,7 +978,7 @@ one is chosen.  The thread chosen is arbitrary; thus its usually safer to call n
               <value>
     <![CDATA[
 //StatementExpression/PrimaryExpression
-[count(PrimarySuffix/Arguments/ArgumentList) = 0]
+[PrimarySuffix/Arguments[@ArgumentCount = '0']]
 [
 PrimaryPrefix[./Name[@Image='notify' or ends-with(@Image,'.notify')]
 or ../PrimarySuffix/@Image='notify'
diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/UseNotifyAllInsteadOfNotify.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/UseNotifyAllInsteadOfNotify.xml
index bfa7976022..88b6444988 100644
--- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/UseNotifyAllInsteadOfNotify.xml
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/UseNotifyAllInsteadOfNotify.xml
@@ -79,4 +79,17 @@ public class Foo {
 }
      ]]></code>
     </test-code>
+
+    <test-code>
+        <description>#1438 UseNotifyAllInsteadOfNotify gives false positive</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+public class FlasePositive {
+    public static void main(String[] args) {
+        boolean notify;
+        notify = true;
+    }
+}
+        ]]></code>
+    </test-code>
 </test-data>
diff --git a/src/site/markdown/overview/changelog.md b/src/site/markdown/overview/changelog.md
index b5d9f4e884..81cf73fd8d 100644
--- a/src/site/markdown/overview/changelog.md
+++ b/src/site/markdown/overview/changelog.md
@@ -19,6 +19,8 @@
 
 **Bugfixes:**
 
+*   java-design/UseNotifyAllInsteadOfNotify
+    *   [#1438](https://sourceforge.net/p/pmd/bugs/1438/): UseNotifyAllInsteadOfNotify gives false positive
 *   java-finalizers/AvoidCallingFinalize
     *   [#1440](https://sourceforge.net/p/pmd/bugs/1440/): NPE in AvoidCallingFinalize
 *   java-optimizations/RedundantFieldInitializer