diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/AbstractJavaAccessNode.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/AbstractJavaAccessNode.java index a63b514159..d0339fabe8 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/AbstractJavaAccessNode.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/AbstractJavaAccessNode.java @@ -120,8 +120,6 @@ public abstract class AbstractJavaAccessNode extends AbstractJavaNode implements setModifier(isDefault, DEFAULT); } - // TODO: fix the rule - around binary expressions the parentheses are needed... - @SuppressWarnings("PMD.UselessParentheses") private boolean isModifier(int mask) { return (modifiers & mask) == mask; } diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessParentheses.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessParentheses.xml index 6618aec8ba..994f3b5b6b 100644 --- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessParentheses.xml +++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessParentheses.xml @@ -460,4 +460,15 @@ public class Useless { ]]> + + FP on binary operator + 0 + +