From 4a395ee8b7dcab362c2bd6e6b451554ca69089c7 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Wed, 30 Sep 2015 22:36:00 +0200 Subject: [PATCH 1/9] #1410 Improve description of DefaultPackage rule --- pmd-java/src/main/resources/rulesets/java/controversial.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pmd-java/src/main/resources/rulesets/java/controversial.xml b/pmd-java/src/main/resources/rulesets/java/controversial.xml index 1627cc401d..364d330180 100644 --- a/pmd-java/src/main/resources/rulesets/java/controversial.xml +++ b/pmd-java/src/main/resources/rulesets/java/controversial.xml @@ -278,7 +278,8 @@ public class Foo { class="net.sourceforge.pmd.lang.rule.XPathRule" externalInfoUrl="${pmd.website.baseurl}/rules/java/controversial.html#DefaultPackage"> -Use explicit scoping instead of the default package private level. +Use explicit scoping instead of accidental usage of default package private level. +The rule allows methods and fields annotated with Guava's @VisibleForTesting. 3 From 87db2a573624768acdca4734416a09466a4f1e51 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sat, 3 Oct 2015 16:49:36 +0200 Subject: [PATCH 2/9] Update changelog --- src/site/markdown/overview/changelog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/src/site/markdown/overview/changelog.md b/src/site/markdown/overview/changelog.md index 830c40c13c..e034508139 100644 --- a/src/site/markdown/overview/changelog.md +++ b/src/site/markdown/overview/changelog.md @@ -17,6 +17,7 @@ **Pull Requests:** +* [#71](https://github.com/pmd/pmd/pull/71): #1410 Improve description of DefaultPackage rule **Bugfixes:** From 3bf91a84d645c93cf1b498dc4db44322d1c8e0e4 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sat, 3 Oct 2015 16:57:16 +0200 Subject: [PATCH 3/9] travis - don't try to deploy pull request builds... --- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 149d8e77e4..fc362c5360 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,7 +2,9 @@ language: java matrix: include: - jdk: oraclejdk7 - script: mvn test deploy --settings .travis-settings.xml + script: + - '[ "${TRAVIS_PULL_REQUEST}" = "false" ] && mvn test deploy --settings .travis-settings.xml' + - '[ "${TRAVIS_PULL_REQUEST}" = "false" ] || mvn test' - jdk: oraclejdk8 script: mvn test notifications: From 73fe285b1a02cab9c8589f373ca4df9e2782f875 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sat, 3 Oct 2015 17:36:07 +0200 Subject: [PATCH 4/9] #1418 RedundantFieldInitializer false positive with large long value --- .../optimizations/RedundantFieldInitializerRule.java | 2 +- .../optimizations/xml/RedundantFieldInitializer.xml | 10 ++++++++++ src/site/markdown/overview/changelog.md | 12 +++++++----- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/optimizations/RedundantFieldInitializerRule.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/optimizations/RedundantFieldInitializerRule.java index 3fc599ffb6..f9d18882f5 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/optimizations/RedundantFieldInitializerRule.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/optimizations/RedundantFieldInitializerRule.java @@ -100,7 +100,7 @@ public class RedundantFieldInitializerRule extends AbstractJavaRule { value = (int) literal.getImage().charAt(1); } - if (value.intValue() == 0) { + if (value.longValue() == 0) { addViolation(data, variableDeclarator); } } diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/optimizations/xml/RedundantFieldInitializer.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/optimizations/xml/RedundantFieldInitializer.xml index 268dbab4f0..ad2450bc61 100644 --- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/optimizations/xml/RedundantFieldInitializer.xml +++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/optimizations/xml/RedundantFieldInitializer.xml @@ -1292,4 +1292,14 @@ public class Bar { } + + + #1418 RedundantFieldInitializer false positive with large long value + 0 + + diff --git a/src/site/markdown/overview/changelog.md b/src/site/markdown/overview/changelog.md index e034508139..f2060eded7 100644 --- a/src/site/markdown/overview/changelog.md +++ b/src/site/markdown/overview/changelog.md @@ -22,14 +22,16 @@ **Bugfixes:** * java-controversial/DefaultPackage: - * [#1410](https://sourceforge.net/p/pmd/bugs/1410/): DefaultPackage triggers on field annotated with @VisibleForTesting + * [#1410](https://sourceforge.net/p/pmd/bugs/1410/): DefaultPackage triggers on field annotated with @VisibleForTesting * java-design/CloseResource: - * [#1387](https://sourceforge.net/p/pmd/bugs/1387/): CloseResource has false positive for ResultSet + * [#1387](https://sourceforge.net/p/pmd/bugs/1387/): CloseResource has false positive for ResultSet +* java-optimizations/RedundantFieldInitializer + * [#1418](https://sourceforge.net/p/pmd/bugs/1418/): RedundantFieldInitializer false positive with large long value * java-strings/InsufficientStringBufferDeclaration: - * [#1409](https://sourceforge.net/p/pmd/bugs/1409/): NullPointerException in InsufficientStringBufferRule - * [#1413](https://sourceforge.net/p/pmd/bugs/1413/): False positive StringBuffer constructor with ?: int value + * [#1409](https://sourceforge.net/p/pmd/bugs/1409/): NullPointerException in InsufficientStringBufferRule + * [#1413](https://sourceforge.net/p/pmd/bugs/1413/): False positive StringBuffer constructor with ?: int value * java-unnecessary/UselessParentheses: - * [#1407](https://sourceforge.net/p/pmd/bugs/1407/): UselessParentheses "&" and "+" operator precedence + * [#1407](https://sourceforge.net/p/pmd/bugs/1407/): UselessParentheses "&" and "+" operator precedence **API Changes:** From 98e0c1f91468441eed2d641ff4fe5a1bff3c6e43 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sun, 4 Oct 2015 12:40:49 +0200 Subject: [PATCH 5/9] Prepare pmd release 5.3.5 --- src/site/markdown/overview/changelog.md | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/site/markdown/overview/changelog.md b/src/site/markdown/overview/changelog.md index f2060eded7..d9013de21a 100644 --- a/src/site/markdown/overview/changelog.md +++ b/src/site/markdown/overview/changelog.md @@ -1,14 +1,8 @@ # Changelog -## ????? - 5.3.5-SNAPSHOT +## 04-October-2015 - 5.3.5 -**New Supported Languages:** - - -**Feature Request and Improvements:** - - -**New/Modified/Deprecated Rules:** +**Modified Rules:** * java-design/CloseResource: New Property *closeAsDefaultTarget* which is *true* by default to stay backwards compatible. If this property is *true*, the rule will make sure, that `close` itself is @@ -33,6 +27,3 @@ * java-unnecessary/UselessParentheses: * [#1407](https://sourceforge.net/p/pmd/bugs/1407/): UselessParentheses "&" and "+" operator precedence - -**API Changes:** - From f357da73b64973eb47b117f671b380643ae15645 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sun, 4 Oct 2015 12:48:25 +0200 Subject: [PATCH 6/9] [maven-release-plugin] prepare release pmd_releases/5.3.5 --- pmd-core/pom.xml | 2 +- pmd-cpp/pom.xml | 2 +- pmd-cs/pom.xml | 2 +- pmd-dist/pom.xml | 2 +- pmd-fortran/pom.xml | 2 +- pmd-go/pom.xml | 2 +- pmd-java/pom.xml | 2 +- pmd-javascript/pom.xml | 2 +- pmd-jsp/pom.xml | 2 +- pmd-matlab/pom.xml | 2 +- pmd-objectivec/pom.xml | 2 +- pmd-php/pom.xml | 2 +- pmd-plsql/pom.xml | 2 +- pmd-python/pom.xml | 2 +- pmd-ruby/pom.xml | 2 +- pmd-scala/pom.xml | 2 +- pmd-test/pom.xml | 2 +- pmd-vm/pom.xml | 2 +- pmd-xml/pom.xml | 2 +- pom.xml | 4 ++-- 20 files changed, 21 insertions(+), 21 deletions(-) diff --git a/pmd-core/pom.xml b/pmd-core/pom.xml index 6821d7dd0a..aa3aaeeaca 100644 --- a/pmd-core/pom.xml +++ b/pmd-core/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-cpp/pom.xml b/pmd-cpp/pom.xml index 520ff8e364..fef9475633 100644 --- a/pmd-cpp/pom.xml +++ b/pmd-cpp/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-cs/pom.xml b/pmd-cs/pom.xml index 2a1a332152..0f4d47e294 100644 --- a/pmd-cs/pom.xml +++ b/pmd-cs/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-dist/pom.xml b/pmd-dist/pom.xml index 10db4ab066..bd5f5f329d 100644 --- a/pmd-dist/pom.xml +++ b/pmd-dist/pom.xml @@ -8,7 +8,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-fortran/pom.xml b/pmd-fortran/pom.xml index 069067aba3..0bfae6c3f2 100644 --- a/pmd-fortran/pom.xml +++ b/pmd-fortran/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-go/pom.xml b/pmd-go/pom.xml index 7516b94844..f18f459138 100644 --- a/pmd-go/pom.xml +++ b/pmd-go/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-java/pom.xml b/pmd-java/pom.xml index c96180d6ba..75d57cdfba 100644 --- a/pmd-java/pom.xml +++ b/pmd-java/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-javascript/pom.xml b/pmd-javascript/pom.xml index 2901dbc42e..1718b91b8a 100644 --- a/pmd-javascript/pom.xml +++ b/pmd-javascript/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-jsp/pom.xml b/pmd-jsp/pom.xml index c639c8f199..16e648a354 100644 --- a/pmd-jsp/pom.xml +++ b/pmd-jsp/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-matlab/pom.xml b/pmd-matlab/pom.xml index 0b35f68849..5e61de215f 100644 --- a/pmd-matlab/pom.xml +++ b/pmd-matlab/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-objectivec/pom.xml b/pmd-objectivec/pom.xml index df3e6a2bea..21631c80ca 100644 --- a/pmd-objectivec/pom.xml +++ b/pmd-objectivec/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-php/pom.xml b/pmd-php/pom.xml index 39598aece0..46db2b450e 100644 --- a/pmd-php/pom.xml +++ b/pmd-php/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-plsql/pom.xml b/pmd-plsql/pom.xml index a43d89b8b2..20b7e60dd9 100644 --- a/pmd-plsql/pom.xml +++ b/pmd-plsql/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-python/pom.xml b/pmd-python/pom.xml index 764dfb0df8..99bf164dd4 100644 --- a/pmd-python/pom.xml +++ b/pmd-python/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-ruby/pom.xml b/pmd-ruby/pom.xml index 283bb2d972..51f86aaf85 100644 --- a/pmd-ruby/pom.xml +++ b/pmd-ruby/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-scala/pom.xml b/pmd-scala/pom.xml index 9ca35958e6..d4a9de4afe 100644 --- a/pmd-scala/pom.xml +++ b/pmd-scala/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-test/pom.xml b/pmd-test/pom.xml index 42d021c3f7..94793a28bd 100644 --- a/pmd-test/pom.xml +++ b/pmd-test/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-vm/pom.xml b/pmd-vm/pom.xml index 8252f8ba57..5acacd2b66 100644 --- a/pmd-vm/pom.xml +++ b/pmd-vm/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pmd-xml/pom.xml b/pmd-xml/pom.xml index 10e7cd088c..7ec05f5e72 100644 --- a/pmd-xml/pom.xml +++ b/pmd-xml/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 diff --git a/pom.xml b/pom.xml index 7bfb7a0a9b..61e39feb6a 100644 --- a/pom.xml +++ b/pom.xml @@ -3,7 +3,7 @@ 4.0.0 net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.5 pom PMD @@ -244,7 +244,7 @@ scm:git:git://github.com/pmd/pmd.git scm:git:ssh://git@github.com/pmd/pmd.git https://github.com/pmd/pmd - pmd/5.3.x + pmd_releases/5.3.5 From af9f9d477d164d6036f60aa0e6660bc722f11f99 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sun, 4 Oct 2015 12:48:25 +0200 Subject: [PATCH 7/9] [maven-release-plugin] prepare for next development iteration --- pmd-core/pom.xml | 2 +- pmd-cpp/pom.xml | 2 +- pmd-cs/pom.xml | 2 +- pmd-dist/pom.xml | 2 +- pmd-fortran/pom.xml | 2 +- pmd-go/pom.xml | 2 +- pmd-java/pom.xml | 2 +- pmd-javascript/pom.xml | 2 +- pmd-jsp/pom.xml | 2 +- pmd-matlab/pom.xml | 2 +- pmd-objectivec/pom.xml | 2 +- pmd-php/pom.xml | 2 +- pmd-plsql/pom.xml | 2 +- pmd-python/pom.xml | 2 +- pmd-ruby/pom.xml | 2 +- pmd-scala/pom.xml | 2 +- pmd-test/pom.xml | 2 +- pmd-vm/pom.xml | 2 +- pmd-xml/pom.xml | 2 +- pom.xml | 4 ++-- 20 files changed, 21 insertions(+), 21 deletions(-) diff --git a/pmd-core/pom.xml b/pmd-core/pom.xml index aa3aaeeaca..3f653b6707 100644 --- a/pmd-core/pom.xml +++ b/pmd-core/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-cpp/pom.xml b/pmd-cpp/pom.xml index fef9475633..482aaa5a8f 100644 --- a/pmd-cpp/pom.xml +++ b/pmd-cpp/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-cs/pom.xml b/pmd-cs/pom.xml index 0f4d47e294..b83a2f72a0 100644 --- a/pmd-cs/pom.xml +++ b/pmd-cs/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-dist/pom.xml b/pmd-dist/pom.xml index bd5f5f329d..84aafc2677 100644 --- a/pmd-dist/pom.xml +++ b/pmd-dist/pom.xml @@ -8,7 +8,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-fortran/pom.xml b/pmd-fortran/pom.xml index 0bfae6c3f2..3da7de1d52 100644 --- a/pmd-fortran/pom.xml +++ b/pmd-fortran/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-go/pom.xml b/pmd-go/pom.xml index f18f459138..0f7dd0e6a8 100644 --- a/pmd-go/pom.xml +++ b/pmd-go/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-java/pom.xml b/pmd-java/pom.xml index 75d57cdfba..5b69b2bac7 100644 --- a/pmd-java/pom.xml +++ b/pmd-java/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-javascript/pom.xml b/pmd-javascript/pom.xml index 1718b91b8a..b125340695 100644 --- a/pmd-javascript/pom.xml +++ b/pmd-javascript/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-jsp/pom.xml b/pmd-jsp/pom.xml index 16e648a354..da08657a35 100644 --- a/pmd-jsp/pom.xml +++ b/pmd-jsp/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-matlab/pom.xml b/pmd-matlab/pom.xml index 5e61de215f..102187dd3a 100644 --- a/pmd-matlab/pom.xml +++ b/pmd-matlab/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-objectivec/pom.xml b/pmd-objectivec/pom.xml index 21631c80ca..229827eec9 100644 --- a/pmd-objectivec/pom.xml +++ b/pmd-objectivec/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-php/pom.xml b/pmd-php/pom.xml index 46db2b450e..38cebdcf94 100644 --- a/pmd-php/pom.xml +++ b/pmd-php/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-plsql/pom.xml b/pmd-plsql/pom.xml index 20b7e60dd9..5bb22ae943 100644 --- a/pmd-plsql/pom.xml +++ b/pmd-plsql/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-python/pom.xml b/pmd-python/pom.xml index 99bf164dd4..514bf31b66 100644 --- a/pmd-python/pom.xml +++ b/pmd-python/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-ruby/pom.xml b/pmd-ruby/pom.xml index 51f86aaf85..9681044f7e 100644 --- a/pmd-ruby/pom.xml +++ b/pmd-ruby/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-scala/pom.xml b/pmd-scala/pom.xml index d4a9de4afe..e248917b0d 100644 --- a/pmd-scala/pom.xml +++ b/pmd-scala/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-test/pom.xml b/pmd-test/pom.xml index 94793a28bd..ed39dd390e 100644 --- a/pmd-test/pom.xml +++ b/pmd-test/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-vm/pom.xml b/pmd-vm/pom.xml index 5acacd2b66..63c75f8fec 100644 --- a/pmd-vm/pom.xml +++ b/pmd-vm/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pmd-xml/pom.xml b/pmd-xml/pom.xml index 7ec05f5e72..bbfb756b0e 100644 --- a/pmd-xml/pom.xml +++ b/pmd-xml/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT diff --git a/pom.xml b/pom.xml index 61e39feb6a..da8098d0f4 100644 --- a/pom.xml +++ b/pom.xml @@ -3,7 +3,7 @@ 4.0.0 net.sourceforge.pmd pmd - 5.3.5 + 5.3.6-SNAPSHOT pom PMD @@ -244,7 +244,7 @@ scm:git:git://github.com/pmd/pmd.git scm:git:ssh://git@github.com/pmd/pmd.git https://github.com/pmd/pmd - pmd_releases/5.3.5 + pmd/5.3.x From 79e9b7616a4f8c72af59d61aeca88313a8ed64f7 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sun, 4 Oct 2015 13:54:43 +0200 Subject: [PATCH 8/9] Prepare next development version --- pmd-java8/pom.xml | 2 +- src/site/markdown/overview/changelog-old.md | 28 +++++++++++++++++++++ src/site/markdown/overview/changelog.md | 26 +++++-------------- 3 files changed, 35 insertions(+), 21 deletions(-) diff --git a/pmd-java8/pom.xml b/pmd-java8/pom.xml index 89cdcc553e..1fc2151c74 100644 --- a/pmd-java8/pom.xml +++ b/pmd-java8/pom.xml @@ -7,7 +7,7 @@ net.sourceforge.pmd pmd - 5.3.5-SNAPSHOT + 5.3.6-SNAPSHOT diff --git a/src/site/markdown/overview/changelog-old.md b/src/site/markdown/overview/changelog-old.md index b57c81f344..07a0782762 100644 --- a/src/site/markdown/overview/changelog-old.md +++ b/src/site/markdown/overview/changelog-old.md @@ -4,6 +4,34 @@ Previous versions of PMD can be downloaded here: http://sourceforge.net/projects/pmd/files/pmd/ +## 04-October-2015 - 5.3.5 + +**Modified Rules:** + +* java-design/CloseResource: New Property *closeAsDefaultTarget* which is *true* by default to stay + backwards compatible. If this property is *true*, the rule will make sure, that `close` itself is + always considered as a *closeTarget* - no matter whether it is configured with the *closeTargets* property + or not. + +**Pull Requests:** + +* [#71](https://github.com/pmd/pmd/pull/71): #1410 Improve description of DefaultPackage rule + +**Bugfixes:** + +* java-controversial/DefaultPackage: + * [#1410](https://sourceforge.net/p/pmd/bugs/1410/): DefaultPackage triggers on field annotated with @VisibleForTesting +* java-design/CloseResource: + * [#1387](https://sourceforge.net/p/pmd/bugs/1387/): CloseResource has false positive for ResultSet +* java-optimizations/RedundantFieldInitializer + * [#1418](https://sourceforge.net/p/pmd/bugs/1418/): RedundantFieldInitializer false positive with large long value +* java-strings/InsufficientStringBufferDeclaration: + * [#1409](https://sourceforge.net/p/pmd/bugs/1409/): NullPointerException in InsufficientStringBufferRule + * [#1413](https://sourceforge.net/p/pmd/bugs/1413/): False positive StringBuffer constructor with ?: int value +* java-unnecessary/UselessParentheses: + * [#1407](https://sourceforge.net/p/pmd/bugs/1407/): UselessParentheses "&" and "+" operator precedence + + ## 18-September-2015 - 5.3.4 **Bugfixes:** diff --git a/src/site/markdown/overview/changelog.md b/src/site/markdown/overview/changelog.md index d9013de21a..6722b0f59e 100644 --- a/src/site/markdown/overview/changelog.md +++ b/src/site/markdown/overview/changelog.md @@ -1,29 +1,15 @@ # Changelog -## 04-October-2015 - 5.3.5 +## ????? - 5.3.6-SNAPSHOT -**Modified Rules:** +**New Supported Languages:** -* java-design/CloseResource: New Property *closeAsDefaultTarget* which is *true* by default to stay - backwards compatible. If this property is *true*, the rule will make sure, that `close` itself is - always considered as a *closeTarget* - no matter whether it is configured with the *closeTargets* property - or not. +**Feature Request and Improvements:** + +**New/Modified/Deprecated Rules:** **Pull Requests:** -* [#71](https://github.com/pmd/pmd/pull/71): #1410 Improve description of DefaultPackage rule - **Bugfixes:** -* java-controversial/DefaultPackage: - * [#1410](https://sourceforge.net/p/pmd/bugs/1410/): DefaultPackage triggers on field annotated with @VisibleForTesting -* java-design/CloseResource: - * [#1387](https://sourceforge.net/p/pmd/bugs/1387/): CloseResource has false positive for ResultSet -* java-optimizations/RedundantFieldInitializer - * [#1418](https://sourceforge.net/p/pmd/bugs/1418/): RedundantFieldInitializer false positive with large long value -* java-strings/InsufficientStringBufferDeclaration: - * [#1409](https://sourceforge.net/p/pmd/bugs/1409/): NullPointerException in InsufficientStringBufferRule - * [#1413](https://sourceforge.net/p/pmd/bugs/1413/): False positive StringBuffer constructor with ?: int value -* java-unnecessary/UselessParentheses: - * [#1407](https://sourceforge.net/p/pmd/bugs/1407/): UselessParentheses "&" and "+" operator precedence - +**API Changes:** From 84c407f5d24254c6a265763640eac944a18b0954 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sun, 4 Oct 2015 14:07:12 +0200 Subject: [PATCH 9/9] add src zip file in do-release.sh upload instructions --- do-release.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/do-release.sh b/do-release.sh index bb641e66e1..aba9a52db5 100755 --- a/do-release.sh +++ b/do-release.sh @@ -302,6 +302,7 @@ echo " * Set the title: PMD ${RELEASE_VERSION} ($(date -u +%d-%B-%Y))" echo " * copy/paste the changelog.md" echo " * Upload the binary zip file" echo " * Upload the doc zip file" +echo " * Upload the src zip file" echo echo "Press enter to continue..." read