From 382c8ca9289018050b45d32224db465efd87e092 Mon Sep 17 00:00:00 2001
From: Sergey <sergey.gorbaty@salesforce.com>
Date: Tue, 28 Feb 2017 09:45:11 -0800
Subject: [PATCH] Typo fix and tests

---
 .../pmd/lang/vf/rule/security/VfUnescapeElRule.java      | 2 +-
 .../pmd/lang/vf/rule/security/xml/VfUnescapeEl.xml       | 9 ++++-----
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/pmd-visualforce/src/main/java/net/sourceforge/pmd/lang/vf/rule/security/VfUnescapeElRule.java b/pmd-visualforce/src/main/java/net/sourceforge/pmd/lang/vf/rule/security/VfUnescapeElRule.java
index b500206449..b4154ff024 100644
--- a/pmd-visualforce/src/main/java/net/sourceforge/pmd/lang/vf/rule/security/VfUnescapeElRule.java
+++ b/pmd-visualforce/src/main/java/net/sourceforge/pmd/lang/vf/rule/security/VfUnescapeElRule.java
@@ -38,7 +38,7 @@ public class VfUnescapeElRule extends AbstractVfRule {
     private static final String APEX_OUTPUT_TEXT = "apex:outputtext";
     private static final String APEX_PAGE_MESSAGE = "apex:pagemessage";
     private static final String APEX_PAGE_MESSAGES = "apex:pagemessages";
-    private static final String APEX_SELECT_OPTION = "apex:selectoption ";
+    private static final String APEX_SELECT_OPTION = "apex:selectoption";
     private static final String FALSE = "false";
 
     @Override
diff --git a/pmd-visualforce/src/test/resources/net/sourceforge/pmd/lang/vf/rule/security/xml/VfUnescapeEl.xml b/pmd-visualforce/src/test/resources/net/sourceforge/pmd/lang/vf/rule/security/xml/VfUnescapeEl.xml
index 15ae9575dc..6aac4cbabf 100644
--- a/pmd-visualforce/src/test/resources/net/sourceforge/pmd/lang/vf/rule/security/xml/VfUnescapeEl.xml
+++ b/pmd-visualforce/src/test/resources/net/sourceforge/pmd/lang/vf/rule/security/xml/VfUnescapeEl.xml
@@ -226,17 +226,16 @@ No XSS via EL via param binding
 
 	<test-code>
 		<description><![CDATA[
-No XSS via EL via param binding
+XSS via item value
      ]]></description>
-		<expected-problems>0</expected-problems>
+		<expected-problems>3</expected-problems>
 		<code><![CDATA[
 <apex:page>
     <apex:form>
         <apex:selectList value="{!string}" size="1">
             <apex:selectOption itemValue='{!XSS}' itemLabel="Red" itemEscaped="false"/>
             <apex:selectOption itemValue={!XSS} itemLabel="Blue" itemEscaped="false"/>
-            <apex:selectOption itemValue="{!XSS}" itemLabel="Green" itemEscaped="false"/>
-            
+            <apex:selectOption itemValue="{!XSS}" itemLabel="Green" itemEscaped="false"/>            
         </apex:selectList> 
     </apex:form>
 </apex:page>
@@ -252,7 +251,7 @@ No XSS with escaped EL
 		<expected-problems>0</expected-problems>
 		<code><![CDATA[
 <apex:page>
-	<apex:outputText value=" {!HTMLENCODE(myTextField)}" escape="false"/>
+	<apex:outputText value=" {!HTMLENCODE(myTextField) }" escape="false"/>
 </apex:page>    
 ]]></code>
 		<source-type>vf</source-type>