From 396921563547ad0812e82e4fcfe7a3c939e924fb Mon Sep 17 00:00:00 2001
From: Andreas Dangel <andreas.dangel@pmd-code.org>
Date: Thu, 3 Mar 2022 21:09:49 +0100
Subject: [PATCH] Update ruleset, add ruleset factory test

Using pmd.website.baseurl parameter
---
 pmd-kotlin/pom.xml                                     |  1 -
 .../main/resources/category/kotlin/bestpractices.xml   |  5 ++---
 .../pmd/lang/kotlin/RuleSetFactoryTest.java            | 10 ++++++++++
 3 files changed, 12 insertions(+), 4 deletions(-)
 create mode 100644 pmd-kotlin/src/test/java/net/sourceforge/pmd/lang/kotlin/RuleSetFactoryTest.java

diff --git a/pmd-kotlin/pom.xml b/pmd-kotlin/pom.xml
index 54d10fb5df..5c8ecab013 100644
--- a/pmd-kotlin/pom.xml
+++ b/pmd-kotlin/pom.xml
@@ -16,7 +16,6 @@
     </properties>
 
     <build>
-        <!-- needed for pmd sonar plugin -->
         <resources>
             <resource>
                 <directory>${project.basedir}/src/main/resources</directory>
diff --git a/pmd-kotlin/src/main/resources/category/kotlin/bestpractices.xml b/pmd-kotlin/src/main/resources/category/kotlin/bestpractices.xml
index 48512462ce..30a88668f0 100644
--- a/pmd-kotlin/src/main/resources/category/kotlin/bestpractices.xml
+++ b/pmd-kotlin/src/main/resources/category/kotlin/bestpractices.xml
@@ -10,12 +10,11 @@ Rules which enforce generally accepted best practices.
     </description>
 
     <rule name="FunctionNameTooShort"
-          since="7.0"
+          since="7.0.0"
           language="kotlin"
           message="Function names should have non-cryptic and clear names."
           class="net.sourceforge.pmd.lang.rule.XPathRule"
-          typeResolution="true"
-          externalInfoUrl="https://pmd.github.io/pmd/pmd_rules_kotlin_bestpractices.html#functionametooshort">
+          externalInfoUrl="${pmd.website.baseurl}/pmd_rules_kotlin_bestpractices.html#functionametooshort">
         <description>
             Function names should be easy to understand and describe the intention. Makes developers happy.
         </description>
diff --git a/pmd-kotlin/src/test/java/net/sourceforge/pmd/lang/kotlin/RuleSetFactoryTest.java b/pmd-kotlin/src/test/java/net/sourceforge/pmd/lang/kotlin/RuleSetFactoryTest.java
new file mode 100644
index 0000000000..ab10c8550b
--- /dev/null
+++ b/pmd-kotlin/src/test/java/net/sourceforge/pmd/lang/kotlin/RuleSetFactoryTest.java
@@ -0,0 +1,10 @@
+/*
+ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
+ */
+
+package net.sourceforge.pmd.lang.kotlin;
+
+import net.sourceforge.pmd.AbstractRuleSetFactoryTest;
+
+public class RuleSetFactoryTest extends AbstractRuleSetFactoryTest {
+}