From 4d127404d3694dbf2c75a26d13c3dc2615cfbaec Mon Sep 17 00:00:00 2001
From: Ryan Gustafson <rgustav@users.sourceforge.net>
Date: Fri, 28 Mar 2008 22:45:43 +0000
Subject: [PATCH] Fix bug 1928009 - Error using migration ruleset in PMD 4.2

AbstractRuleChainVisitor changed an 'if' to a 'while' to ensure all RuleReferences were followed to find the real underlying Rule.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5942 51baf565-9d33-0410-a72c-fc3788e3496d
---
 pmd/etc/changelog.txt                                     | 1 +
 pmd/rulesets/internal/dogfood.xml                         | 6 +++++-
 pmd/src/net/sourceforge/pmd/AbstractRuleChainVisitor.java | 8 ++++----
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/pmd/etc/changelog.txt b/pmd/etc/changelog.txt
index 4ea468d738..0085a2f8bf 100644
--- a/pmd/etc/changelog.txt
+++ b/pmd/etc/changelog.txt
@@ -1,6 +1,7 @@
 ???? - 4.2.1:
 
 '41' and '42' shortcuts for rulesets added
+Fixed bug 1928009 - Error using migration ruleset in PMD 4.2
 
 March 25, 2008 - 4.2:
 
diff --git a/pmd/rulesets/internal/dogfood.xml b/pmd/rulesets/internal/dogfood.xml
index 3c3305d518..448cb5c4bf 100644
--- a/pmd/rulesets/internal/dogfood.xml
+++ b/pmd/rulesets/internal/dogfood.xml
@@ -72,6 +72,10 @@ Rules to check PMD itself
     <rule ref="rulesets/unusedcode.xml/UnusedLocalVariable"/>
     <!-- Unused code End-->
 
-    <rule ref="rulesets/migrating.xml"/>
+    <!-- Specifically reference via other referencing RuleSets to test Reference to Reference -->
+    <rule ref="rulesets/migrating_to_13.xml"/>
+    <rule ref="rulesets/migrating_to_14.xml"/>
+    <rule ref="rulesets/migrating_to_15.xml"/>
+    <rule ref="rulesets/migrating_to_junit4.xml"/>
 
 </ruleset>
diff --git a/pmd/src/net/sourceforge/pmd/AbstractRuleChainVisitor.java b/pmd/src/net/sourceforge/pmd/AbstractRuleChainVisitor.java
index 6de835a91e..2adcc1e77a 100644
--- a/pmd/src/net/sourceforge/pmd/AbstractRuleChainVisitor.java
+++ b/pmd/src/net/sourceforge/pmd/AbstractRuleChainVisitor.java
@@ -57,10 +57,10 @@ public abstract class AbstractRuleChainVisitor implements RuleChainVisitor {
             for (int j = 0; j < nodeNames.size(); j++) {
                 List<SimpleNode> nodes = nodeNameToNodes.get(nodeNames.get(j));
                 for (SimpleNode node: nodes) {
-                	// Visit with underlying Rule, not the RuleReference
-                	if (rule instanceof RuleReference) {
-                		rule = ((RuleReference)rule).getRule();
-                	}
+                    // Visit with underlying Rule, not the RuleReference
+                    while (rule instanceof RuleReference) {
+                        rule = ((RuleReference)rule).getRule();
+                    }
                     visit(rule, node, ctx);
                 }
                 visits += nodes.size();