From 371db089c999caaa66987cb4d812c85e358c2e28 Mon Sep 17 00:00:00 2001 From: Ignacio Tirabasso Date: Thu, 21 Jan 2016 15:07:06 -0300 Subject: [PATCH 1/2] Change EmptyMethodInAbstractClassShouldBeAbstract rule's description. Summary: Change EmptyMethodInAbstractClassShouldBeAbstract rule's description. Test Plan: run tests Reviewers: jmsotuyo Differential Revision: http://ph.monits.com/D14582 --- pmd-java/src/main/resources/rulesets/java/design.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pmd-java/src/main/resources/rulesets/java/design.xml b/pmd-java/src/main/resources/rulesets/java/design.xml index dc8044c8ed..08f2bfb33b 100644 --- a/pmd-java/src/main/resources/rulesets/java/design.xml +++ b/pmd-java/src/main/resources/rulesets/java/design.xml @@ -1599,7 +1599,8 @@ public class Foo { //Should be final externalInfoUrl="${pmd.website.baseurl}/rules/java/design.html#EmptyMethodInAbstractClassShouldBeAbstract"> Empty methods in an abstract class should be tagged as abstract. This helps to remove their inapproprate -usage by developers who should be implementing their own versions in the concrete subclasses. +usage by developers who should be implementing their own versions in the concrete subclasses. +Auto-generated methods could trigger this rule. 1 From 55453cc23d004a5b75ea7d3cb79d725b1adb7908 Mon Sep 17 00:00:00 2001 From: Ignacio Tirabasso Date: Thu, 21 Jan 2016 15:22:48 -0300 Subject: [PATCH 2/2] Fix rule's description. --- pmd-java/src/main/resources/rulesets/java/design.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pmd-java/src/main/resources/rulesets/java/design.xml b/pmd-java/src/main/resources/rulesets/java/design.xml index 08f2bfb33b..1621f5df9d 100644 --- a/pmd-java/src/main/resources/rulesets/java/design.xml +++ b/pmd-java/src/main/resources/rulesets/java/design.xml @@ -1598,9 +1598,8 @@ public class Foo { //Should be final message="An empty method in an abstract class should be abstract instead" externalInfoUrl="${pmd.website.baseurl}/rules/java/design.html#EmptyMethodInAbstractClassShouldBeAbstract"> -Empty methods in an abstract class should be tagged as abstract. This helps to remove their inapproprate +Empty or auto-generated methods in an abstract class should be tagged as abstract. This helps to remove their inapproprate usage by developers who should be implementing their own versions in the concrete subclasses. -Auto-generated methods could trigger this rule. 1