From 5f1b13cadd607b9ae83ab102a45aec586652fa4c Mon Sep 17 00:00:00 2001
From: Andreas Dangel <andreas.dangel@pmd-code.org>
Date: Fri, 6 Sep 2024 19:51:52 +0200
Subject: [PATCH] [apex] Verify StdCyclomaticComplexity with triggers

---
 .../design/StdCyclomaticComplexityTest.java   | 11 +++++++
 .../design/xml/StdCyclomaticComplexity.xml    | 32 +++++++++++++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 pmd-apex/src/test/java/net/sourceforge/pmd/lang/apex/rule/design/StdCyclomaticComplexityTest.java

diff --git a/pmd-apex/src/test/java/net/sourceforge/pmd/lang/apex/rule/design/StdCyclomaticComplexityTest.java b/pmd-apex/src/test/java/net/sourceforge/pmd/lang/apex/rule/design/StdCyclomaticComplexityTest.java
new file mode 100644
index 0000000000..686a99fb1a
--- /dev/null
+++ b/pmd-apex/src/test/java/net/sourceforge/pmd/lang/apex/rule/design/StdCyclomaticComplexityTest.java
@@ -0,0 +1,11 @@
+/**
+ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
+ */
+
+package net.sourceforge.pmd.lang.apex.rule.design;
+
+import net.sourceforge.pmd.test.PmdRuleTst;
+
+class StdCyclomaticComplexityTest extends PmdRuleTst {
+    // no additional unit tests
+}
diff --git a/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/design/xml/StdCyclomaticComplexity.xml b/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/design/xml/StdCyclomaticComplexity.xml
index 21fed889c1..a961cce7ff 100644
--- a/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/design/xml/StdCyclomaticComplexity.xml
+++ b/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/design/xml/StdCyclomaticComplexity.xml
@@ -173,4 +173,36 @@ public class Test {
         <expected-problems>0</expected-problems>
         <code-ref id="constructor-violation"/>
     </test-code>
+
+    <test-code>
+        <description>StdCyclomaticComplexity for triggers</description>
+        <rule-property name="reportLevel">1</rule-property>
+        <expected-problems>3</expected-problems>
+        <expected-messages>
+            <message>The method 'invoke' has a Standard Cyclomatic Complexity of 4.</message>
+            <message>The trigger 'Accounts' has a Standard Cyclomatic Complexity of 4 (Highest = 4).</message>
+            <message>The method 'anotherMethod' has a Standard Cyclomatic Complexity of 3.</message>
+        </expected-messages>
+        <code><![CDATA[
+trigger Accounts on Account (before insert, before update, before delete, after insert, after update, after delete, after undelete) {
+    for(Account acc : Trigger.new) {
+        if(Trigger.isInsert) {
+            // ...
+        }
+
+        // ...
+
+        if(Trigger.isDelete) {
+            // ...
+        }
+    }
+
+    void anotherMethod(Integer i) {
+        if (i == 1) {
+        } else if (i == 2) {
+        }
+    }
+}
+]]></code>
+    </test-code>
 </test-data>