diff --git a/pmd/src/net/sourceforge/pmd/rules/basic/BrokenNullCheck.java b/pmd/src/net/sourceforge/pmd/rules/basic/BrokenNullCheck.java index 9902598a88..4f491956b4 100644 --- a/pmd/src/net/sourceforge/pmd/rules/basic/BrokenNullCheck.java +++ b/pmd/src/net/sourceforge/pmd/rules/basic/BrokenNullCheck.java @@ -40,7 +40,7 @@ public class BrokenNullCheck extends AbstractRule { private void checkForViolations(ASTIfStatement node, Object data, SimpleJavaNode conditionalExpression) { - ASTEqualityExpression equalityExpression = (ASTEqualityExpression)getFirstDirectChildOfType(ASTEqualityExpression.class, conditionalExpression); + ASTEqualityExpression equalityExpression = getFirstDirectChildOfType(ASTEqualityExpression.class, conditionalExpression); if (equalityExpression == null) { return; } @@ -164,11 +164,11 @@ public class BrokenNullCheck extends AbstractRule { return null; //Nothing found } - private Node getFirstDirectChildOfType(Class childType, Node node) { + private T getFirstDirectChildOfType(Class childType, Node node) { for (int i = 0; i < node.jjtGetNumChildren(); i++) { SimpleJavaNode simpleNode = (SimpleJavaNode) node.jjtGetChild(i); if (simpleNode.getClass().equals(childType)) - return simpleNode; + return (T)simpleNode; } return null; }