From 8580745430b9479355bcc657b00fdd3b2b67c315 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Fournier?= <clement.fournier76@gmail.com>
Date: Wed, 3 May 2023 14:03:42 +0200
Subject: [PATCH] Fix #4433

---
 .../main/resources/category/java/bestpractices.xml  |  2 +-
 .../bestpractices/xml/ReplaceHashtableWithMap.xml   | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/pmd-java/src/main/resources/category/java/bestpractices.xml b/pmd-java/src/main/resources/category/java/bestpractices.xml
index 728ab98c9b..b2e2f655eb 100644
--- a/pmd-java/src/main/resources/category/java/bestpractices.xml
+++ b/pmd-java/src/main/resources/category/java/bestpractices.xml
@@ -1281,7 +1281,7 @@ Consider replacing Hashtable usage with the newer java.util.Map if thread safety
         <properties>
             <property name="xpath">
                 <value><![CDATA[
-                //ClassOrInterfaceType[pmd-java:typeIs('java.util.Hashtable')]
+                //ClassOrInterfaceType[pmd-java:typeIsExactly('java.util.Hashtable')]
                 ]]></value>
             </property>
         </properties>
diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/ReplaceHashtableWithMap.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/ReplaceHashtableWithMap.xml
index 58147cad22..96ccaae33c 100644
--- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/ReplaceHashtableWithMap.xml
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/ReplaceHashtableWithMap.xml
@@ -39,4 +39,17 @@ public class Foo {
 }
         ]]></code>
     </test-code>
+    <test-code>
+        <description>Properties #4433</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+            import java.util.Properties;
+            public class Foo {
+                Properties field;
+                void bar(Properties h) {
+                    Properties local;
+                }
+            }
+            ]]></code>
+    </test-code>
 </test-data>