From 8810e58a319df2452d5fc9436e916f0f68fd2638 Mon Sep 17 00:00:00 2001
From: hemanshu070 <hemanshu070@gmail.com>
Date: Thu, 20 Dec 2018 23:13:52 +0530
Subject: [PATCH] This is the change regarding the usediamondoperator #1517

---
 .../resources/category/java/codestyle.xml     | 27 ++++++++
 .../rule/codestyle/UseDiamondOperator.java    |  7 +++
 .../rule/codestyle/xml/UseDiamondOperator.xml | 62 +++++++++++++++++++
 3 files changed, 96 insertions(+)
 create mode 100644 pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/codestyle/UseDiamondOperator.java
 create mode 100644 pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UseDiamondOperator.xml

diff --git a/pmd-java/src/main/resources/category/java/codestyle.xml b/pmd-java/src/main/resources/category/java/codestyle.xml
index b5ded22baf..37ed132429 100644
--- a/pmd-java/src/main/resources/category/java/codestyle.xml
+++ b/pmd-java/src/main/resources/category/java/codestyle.xml
@@ -1809,6 +1809,33 @@ public class Foo {
         </example>
     </rule>
 
+
+    <rule name="UseDiamondOperator"
+          language="java"
+          message="Use diamond operator"
+          class="net.sourceforge.pmd.lang.rule.XPathRule"
+          minimumLanguageVersion="1.7">
+        <description>Use the diamond operator to let the type be inferred</description>
+        <priority>1</priority>
+        <properties>
+            <property name="xpath">
+                <value>
+                    <![CDATA[
+//VariableInitializer
+//PrimaryExpression[not(PrimarySuffix)]
+[not(ancestor::ArgumentList)]
+/PrimaryPrefix/AllocationExpression[ClassOrInterfaceType[@AnonymousClass='false']/TypeArguments//ReferenceType[not(.//TypeArguments)]]
+|
+//StatementExpression[AssignmentOperator][PrimaryExpression/PrimaryPrefix[not(Expression)]]
+//PrimaryExpression[not(PrimarySuffix)]
+[not(ancestor::ArgumentList)]
+/PrimaryPrefix/AllocationExpression[ClassOrInterfaceType[@AnonymousClass='false']/TypeArguments//ReferenceType[not(.//TypeArguments)]]
+]]>
+                </value>
+            </property>
+        </properties>
+    </rule>
+
     <rule name="UnnecessaryFullyQualifiedName"
           language="java"
           since="5.0"
diff --git a/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/codestyle/UseDiamondOperator.java b/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/codestyle/UseDiamondOperator.java
new file mode 100644
index 0000000000..1a62a52ada
--- /dev/null
+++ b/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/codestyle/UseDiamondOperator.java
@@ -0,0 +1,7 @@
+package net.sourceforge.pmd.lang.java.rule.codestyle;
+
+import net.sourceforge.pmd.testframework.PmdRuleTst;
+
+public class UseDiamondOperator extends PmdRuleTst {
+    // no additional unit tests
+}
diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UseDiamondOperator.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UseDiamondOperator.xml
new file mode 100644
index 0000000000..bf7292c4ab
--- /dev/null
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UseDiamondOperator.xml
@@ -0,0 +1,62 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<test-data
+        xmlns="http://pmd.sourceforge.net/rule-tests"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://pmd.sourceforge.net/rule-tests http://pmd.sourceforge.net/rule-tests_1_0_0.xsd">
+    <test-code>
+        <description>Use Diamond</description>
+        <expected-problems>2</expected-problems>
+        <expected-linenumbers>8,11</expected-linenumbers>
+        <code><![CDATA[
+import java.util.ArrayList;
+import java.util.List;
+public class Foo {
+    List<String> field;
+    public void foo() {
+       List<String> strings = new ArrayList<String>();
+       List<String> strings2 = new ArrayList<>();
+       this.field = new ArrayList<String>();
+    }
+}
+     ]]></code>
+    </test-code>
+    <test-code>
+        <description>False positive cases: anonymous classes, methods calls</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+public class Foo {
+    private WeakReference<Class<?>> typeReference;
+    public void foo() {
+        Collections.sort(files, new Comparator<DataSource>() {
+            @Override
+            public int compare(DataSource left, DataSource right) {
+                String leftString = left.getNiceFileName(useShortNames, inputPaths);
+                String rightString = right.getNiceFileName(useShortNames, inputPaths);
+                return leftString.compareTo(rightString);
+            }
+        });
+        final TreeSet<Map.Entry<String, TimedResult>> sortedKeySet = new TreeSet<>(
+            new Comparator<Map.Entry<String, TimedResult>>() {
+                @Override
+                public int compare(final Entry<String, TimedResult> o1, final Entry<String, TimedResult> o2) {
+                    return Long.compare(o1.getValue().selfTimeNanos.get(), o2.getValue().selfTimeNanos.get());
+                }
+            });
+        new ThreadLocal<Queue<TimerEntry>>() {
+            @Override
+            protected Queue<TimerEntry> initialValue() {
+                return Collections.asLifoQueue(new LinkedList<TimerEntry>());
+            }
+        };
+        Iterator<Node> EMPTY_ITERATOR = new ArrayList<Node>().iterator();
+        Class<?> type = null;
+        typeReference = new WeakReference<Class<?>>(type);
+        ((ListNode<E>) rev).reverseCache = new SoftReference<ImmutableList<E>>(this);
+    }
+    public Map<PropertyDescriptor<?>, Object> getOverriddenPropertiesByPropertyDescriptor() {
+        return propertyValues == null ? new HashMap<PropertyDescriptor<?>, Object>() : new HashMap<>(propertyValues);
+    }
+}
+        ]]></code>
+    </test-code>
+</test-data>
\ No newline at end of file