From 4a395ee8b7dcab362c2bd6e6b451554ca69089c7 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Wed, 30 Sep 2015 22:36:00 +0200 Subject: [PATCH 1/2] #1410 Improve description of DefaultPackage rule --- pmd-java/src/main/resources/rulesets/java/controversial.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pmd-java/src/main/resources/rulesets/java/controversial.xml b/pmd-java/src/main/resources/rulesets/java/controversial.xml index 1627cc401d..364d330180 100644 --- a/pmd-java/src/main/resources/rulesets/java/controversial.xml +++ b/pmd-java/src/main/resources/rulesets/java/controversial.xml @@ -278,7 +278,8 @@ public class Foo { class="net.sourceforge.pmd.lang.rule.XPathRule" externalInfoUrl="${pmd.website.baseurl}/rules/java/controversial.html#DefaultPackage"> -Use explicit scoping instead of the default package private level. +Use explicit scoping instead of accidental usage of default package private level. +The rule allows methods and fields annotated with Guava's @VisibleForTesting. 3 From 87db2a573624768acdca4734416a09466a4f1e51 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sat, 3 Oct 2015 16:49:36 +0200 Subject: [PATCH 2/2] Update changelog --- src/site/markdown/overview/changelog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/src/site/markdown/overview/changelog.md b/src/site/markdown/overview/changelog.md index 830c40c13c..e034508139 100644 --- a/src/site/markdown/overview/changelog.md +++ b/src/site/markdown/overview/changelog.md @@ -17,6 +17,7 @@ **Pull Requests:** +* [#71](https://github.com/pmd/pmd/pull/71): #1410 Improve description of DefaultPackage rule **Bugfixes:**