diff --git a/pmd/etc/changelog.txt b/pmd/etc/changelog.txt index 967bb71e85..dbe3efd0d5 100644 --- a/pmd/etc/changelog.txt +++ b/pmd/etc/changelog.txt @@ -15,6 +15,7 @@ New Java rule: ????? ??, 2013 - 5.0.3: +Fixed bug 977: MisplacedNullCheck makes false positives Fixed bug 984: Cyclomatic complexity should treat constructors like methods Fixed bug 985: Suppressed methods shouldn't affect avg CyclomaticComplexity Fixed bug 992: Class java.beans.Statement triggered in CloseResource rule diff --git a/pmd/src/main/resources/rulesets/java/basic.xml b/pmd/src/main/resources/rulesets/java/basic.xml index 1384742f1b..d22ecfcf88 100644 --- a/pmd/src/main/resources/rulesets/java/basic.xml +++ b/pmd/src/main/resources/rulesets/java/basic.xml @@ -386,13 +386,21 @@ Either the check is useless (the variable will never be "null") or it is incorre diff --git a/pmd/src/test/resources/net/sourceforge/pmd/lang/java/rule/basic/xml/MisplacedNullCheck.xml b/pmd/src/test/resources/net/sourceforge/pmd/lang/java/rule/basic/xml/MisplacedNullCheck.xml index f2a827d4e8..3eae96f8c9 100644 --- a/pmd/src/test/resources/net/sourceforge/pmd/lang/java/rule/basic/xml/MisplacedNullCheck.xml +++ b/pmd/src/test/resources/net/sourceforge/pmd/lang/java/rule/basic/xml/MisplacedNullCheck.xml @@ -69,4 +69,17 @@ public class Foo { } ]]> + + #977 MisplacedNullCheck makes false positives + 0 + +