From 9ecc1a84edc336350b91ee43f2f3eb2cc12ca49a Mon Sep 17 00:00:00 2001
From: Andreas Dangel <andreas.dangel@pmd-code.org>
Date: Fri, 28 Apr 2023 09:29:12 +0200
Subject: [PATCH] [doc] UnusedLocalVariable with multiple for loop indices

Closes #4518
---
 docs/pages/release_notes.md                   |  1 +
 .../bestpractices/xml/UnusedLocalVariable.xml | 31 +++++++++++++++++++
 2 files changed, 32 insertions(+)

diff --git a/docs/pages/release_notes.md b/docs/pages/release_notes.md
index 34e44047fe..ef48f70cf1 100644
--- a/docs/pages/release_notes.md
+++ b/docs/pages/release_notes.md
@@ -451,6 +451,7 @@ Language specific fixes:
     * [#3675](https://github.com/pmd/pmd/pull/3675):   \[java] MissingOverride - fix false positive with mixing type vars
     * [#4516](https://github.com/pmd/pmd/issues/4516): \[java] UnusedLocalVariable: false-negative with try-with-resources
     * [#4517](https://github.com/pmd/pmd/issues/4517): \[java] UnusedLocalVariable: false-negative with compound assignments
+    * [#4518](https://github.com/pmd/pmd/issues/4518): \[java] UnusedLocalVariable: false-positive with multiple for-loop indices
 * java-codestyle
     * [#1208](https://github.com/pmd/pmd/issues/1208): \[java] PrematureDeclaration rule false-positive on variable declared to measure time
     * [#1429](https://github.com/pmd/pmd/issues/1429): \[java] PrematureDeclaration as result of method call (false positive)
diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedLocalVariable.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedLocalVariable.xml
index 8482c241ad..5729e8ea8e 100644
--- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedLocalVariable.xml
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedLocalVariable.xml
@@ -509,4 +509,35 @@ public class Foo {
 }
         ]]></code>
     </test-code>
+
+    <test-code>
+        <description>[java] UnusedLocalVariable: false-positive with multiple for-loop indices #4518</description>
+        <expected-problems>4</expected-problems>
+        <expected-linenumbers>3,3,6,15</expected-linenumbers>
+        <expected-messages>
+            <message>Avoid unused local variables such as 'a'.</message>
+            <message>Avoid unused local variables such as 'b'.</message>
+            <message>Avoid unused local variables such as 'b'.</message>
+            <message>Avoid unused local variables such as 'j'.</message>
+        </expected-messages>
+        <code><![CDATA[
+public class UnusedLocalVarsMultiple {
+    public void sample1() {
+        int a = 0, b = 1; // a and b unused (line 3)
+    }
+    public void sample2() {
+        int a = 0, b = a; // only b unused (line 6)
+    }
+    public void sample3() {
+        for (int i = 0; i < 10; i++); // i is loop index, is used and should be ignored
+    }
+    public void sample4() {
+        for (int i = 0, j = 0; i < 10; i++, j++); // i and j are loop indices, both are used (line 12)
+    }
+    public void sample5() {
+        for (int i = 0, j = 0; i < 10; i++); // i and j are loop indices, but j is not used (line 15)
+    }
+}
+]]></code>
+    </test-code>
 </test-data>