diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/sunsecure/ArrayIsStoredDirectlyRule.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/sunsecure/ArrayIsStoredDirectlyRule.java index 21f0446038..9330a1830a 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/sunsecure/ArrayIsStoredDirectlyRule.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/sunsecure/ArrayIsStoredDirectlyRule.java @@ -131,7 +131,7 @@ public class ArrayIsStoredDirectlyRule extends AbstractSunSecureRule { if (val == null) { continue; } - ASTPrimarySuffix foo = se.getFirstDescendantOfType(ASTPrimarySuffix.class); + ASTPrimarySuffix foo = e.getFirstDescendantOfType(ASTPrimarySuffix.class); if (foo != null && foo.isArrayDereference()) { continue; } diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/sunsecure/xml/ArrayIsStoredDirectly.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/sunsecure/xml/ArrayIsStoredDirectly.xml index 1c972dc8fe..7628dfa125 100644 --- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/sunsecure/xml/ArrayIsStoredDirectly.xml +++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/sunsecure/xml/ArrayIsStoredDirectly.xml @@ -175,6 +175,23 @@ public class NotificationPacket { this.message = new String(rawTypeData, StandardCharsets.UTF_8); } } +} + ]]> + + + + #468 False positive when qualifying with this + 0 + diff --git a/src/site/markdown/overview/changelog.md b/src/site/markdown/overview/changelog.md index f1b11ef194..6ba45b697b 100644 --- a/src/site/markdown/overview/changelog.md +++ b/src/site/markdown/overview/changelog.md @@ -71,6 +71,8 @@ Based on those metrics, rules like "GodClass" detection can be implemented more * [#487](https://github.com/pmd/pmd/pull/487): \[java] Fix typeresolution for anonymous extending object * java-controversial * [#408](https://github.com/pmd/pmd/issues/408): \[java] DFA not analyzing asserts +* java-sunsecure + * [#468](https://github.com/pmd/pmd/issues/468): \[java] ArrayIsStoredDirectly false positive * java-unnecessarycode * [#412](https://github.com/pmd/pmd/issues/412): \[java] java-unnecessarycode/UnnecessaryFinalModifier missing cases