From bd2d407253645897d7cf03bd2ee333628c1d8040 Mon Sep 17 00:00:00 2001 From: Brian Remedios Date: Sun, 10 Aug 2008 17:56:19 +0000 Subject: [PATCH] static initialization cleanup git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6358 51baf565-9d33-0410-a72c-fc3788e3496d --- .../UnsynchronizedStaticDateFormatterRule.java | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/pmd/src/net/sourceforge/pmd/lang/java/rule/design/UnsynchronizedStaticDateFormatterRule.java b/pmd/src/net/sourceforge/pmd/lang/java/rule/design/UnsynchronizedStaticDateFormatterRule.java index 70579a72b1..545fafe62b 100644 --- a/pmd/src/net/sourceforge/pmd/lang/java/rule/design/UnsynchronizedStaticDateFormatterRule.java +++ b/pmd/src/net/sourceforge/pmd/lang/java/rule/design/UnsynchronizedStaticDateFormatterRule.java @@ -3,7 +3,6 @@ */ package net.sourceforge.pmd.lang.java.rule.design; -import java.util.HashSet; import java.util.Set; import net.sourceforge.pmd.lang.ast.Node; @@ -14,10 +13,11 @@ import net.sourceforge.pmd.lang.java.ast.ASTSynchronizedStatement; import net.sourceforge.pmd.lang.java.ast.ASTVariableDeclaratorId; import net.sourceforge.pmd.lang.java.rule.AbstractJavaRule; import net.sourceforge.pmd.lang.java.symboltable.NameOccurrence; +import net.sourceforge.pmd.util.CollectionUtil; /** * Using a DateFormatter (SimpleDateFormatter) which is static can cause - * unexpected results when used in a multi threaded environment. This rule will + * unexpected results when used in a multi-threaded environment. This rule will * find static (Simple)DateFormatters which are used in an unsynchronized * manner. * Refer to these Bug Parade issues: @@ -29,13 +29,9 @@ import net.sourceforge.pmd.lang.java.symboltable.NameOccurrence; */ public class UnsynchronizedStaticDateFormatterRule extends AbstractJavaRule { - private static Set targets = new HashSet(4); - static { - targets.add("DateFormat"); - targets.add("SimpleDateFormat"); - targets.add("java.text.DateFormat"); - targets.add("java.text.SimpleDateFormat"); - } + private static Set targets = CollectionUtil.asSet(new String[] { + "DateFormat", "SimpleDateFormat", "java.text.DateFormat","java.text.SimpleDateFormat" + }); @Override public Object visit(ASTFieldDeclaration node, Object data) {