From d1c75ccff4d584a2ef7a6d819ce98b8e64dd155d Mon Sep 17 00:00:00 2001 From: Shubham Date: Wed, 30 Jan 2019 14:57:39 +0530 Subject: [PATCH] Unused Formatter need not be checked for synchronization. --- .../rule/multithreading/UnsynchronizedStaticFormatterRule.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/multithreading/UnsynchronizedStaticFormatterRule.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/multithreading/UnsynchronizedStaticFormatterRule.java index 4402b17ba8..2a1f6b386b 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/multithreading/UnsynchronizedStaticFormatterRule.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/multithreading/UnsynchronizedStaticFormatterRule.java @@ -52,7 +52,7 @@ public class UnsynchronizedStaticFormatterRule extends AbstractJavaRule { } ASTVariableDeclaratorId var = node.getFirstDescendantOfType(ASTVariableDeclaratorId.class); - if (Arrays.asList(threadSafeFormatter).contains(var.getType().getName())) { + if (var.getType() != null && Arrays.asList(threadSafeFormatter).contains(var.getType().getName())) { return data; } for (NameOccurrence occ : var.getUsages()) {