From d42aa3915e1040c4f6ed8f9de0cd99d028332797 Mon Sep 17 00:00:00 2001
From: Andreas Dangel <andreas.dangel@microdoc.com>
Date: Mon, 11 Mar 2019 15:30:33 +0100
Subject: [PATCH] Add property "pmd-designer.version", update release procedure

For now, we'll reference the latest pmd-designer release manually,
that is atm 6.12.0.
This means, if a new pmd-designer should be shipped with a PMD release,
the designer will need to be released first.
---
 do-release.sh                                      | 3 +++
 docs/pages/pmd/projectdocs/committers/releasing.md | 6 ++++++
 pmd-dist/pom.xml                                   | 2 +-
 pom.xml                                            | 1 +
 4 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/do-release.sh b/do-release.sh
index a38a055660..6d397d964c 100755
--- a/do-release.sh
+++ b/do-release.sh
@@ -80,6 +80,9 @@ echo "    the new release based on the release notes"
 echo
 echo "*   Update **../pmd.github.io/_config.yml** to mention the new release"
 echo
+echo "*   Update property `pmd-designer.version` in **pom.xml** to reference the latest pmd-designer release"
+echo "    See <https://search.maven.org/search?q=g:net.sourceforge.pmd%20AND%20a:pmd-ui&core=gav> for the available releases."
+echo
 echo "Press enter to continue..."
 read
 
diff --git a/docs/pages/pmd/projectdocs/committers/releasing.md b/docs/pages/pmd/projectdocs/committers/releasing.md
index 4aeeb7e1a2..034a2b68b7 100644
--- a/docs/pages/pmd/projectdocs/committers/releasing.md
+++ b/docs/pages/pmd/projectdocs/committers/releasing.md
@@ -33,8 +33,10 @@ The date and the version must be updated in `docs/_config.yml`,  e.g.
 pmd:
     version: 6.0.0
     date: 2017-12-15
+    release_type: minor
 ```
 
+The release type could be one of "bugfix", "minor", or "major".
 
 The release notes usual mention any new rules that have been added since the last release.
 Please double check the file `pmd-core/src/main/resources/rulesets/releases/<version>.xml`, so
@@ -43,6 +45,10 @@ that all new rules are listed.
 We maintain a documentation for the [next major release](pmd_next_major_development.html). Copy the API
 changes from the current release notes to this document: `docs/pages/next_major_development.md`.
 
+The designer lives at [pmd/pmd-designer](https://github.com/pmd/pmd-designer).
+Update property `pmd-designer.version` in **pom.xml** to reference the latest pmd-designer release.
+See <https://search.maven.org/search?q=g:net.sourceforge.pmd%20AND%20a:pmd-ui&core=gav> for the available releases.
+
 Check in all (version) changes to branch master or any other branch, from which the release takes place:
 
     $ git commit -a -m "Prepare pmd release <version>"
diff --git a/pmd-dist/pom.xml b/pmd-dist/pom.xml
index 484f64351c..43e1480ef6 100644
--- a/pmd-dist/pom.xml
+++ b/pmd-dist/pom.xml
@@ -242,7 +242,7 @@
                 <dependency>
                     <groupId>net.sourceforge.pmd</groupId>
                     <artifactId>pmd-ui</artifactId>
-                    <version>${project.version}</version>
+                    <version>${pmd-designer.version}</version>
                 </dependency>
             </dependencies>
         </profile>
diff --git a/pom.xml b/pom.xml
index 713516de6e..c57714d9f0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -284,6 +284,7 @@ Additionally it includes CPD, the copy-paste-detector. CPD finds duplicated code
 
         <pmd.build-tools.version>1.4.0</pmd.build-tools.version>
 
+        <pmd-designer.version>6.12.0</pmd-designer.version>
     </properties>
 
     <build>