From e28103ddfa3e7748d3534a88352ac6e3959adc4d Mon Sep 17 00:00:00 2001
From: Xavier Le Vourch <xlv@users.sourceforge.net>
Date: Thu, 25 Oct 2007 01:12:51 +0000
Subject: [PATCH] more restrictive regexp in AvoidUsingHardCodedIP to limit
 false positives

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5579 51baf565-9d33-0410-a72c-fc3788e3496d
---
 .../pmd/rules/basic/xml/AvoidUsingHardCodedIP.xml  | 14 ++++++++++++++
 pmd/rulesets/basic.xml                             |  2 +-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/pmd/regress/test/net/sourceforge/pmd/rules/basic/xml/AvoidUsingHardCodedIP.xml b/pmd/regress/test/net/sourceforge/pmd/rules/basic/xml/AvoidUsingHardCodedIP.xml
index fb0120c387..45dd79c47a 100644
--- a/pmd/regress/test/net/sourceforge/pmd/rules/basic/xml/AvoidUsingHardCodedIP.xml
+++ b/pmd/regress/test/net/sourceforge/pmd/rules/basic/xml/AvoidUsingHardCodedIP.xml
@@ -47,4 +47,18 @@ public class Foo {
 }
      ]]></code>
     </test-code>
+    
+    <test-code>
+        <description><![CDATA[
+Not an ip address string
+     ]]></description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+public class Foo {
+  String ID_MD5 = "1.2.840.113549.2.5";
+  String bar = "testing 1.2.3.4";
+}
+     ]]></code>
+    </test-code>
+
 </test-data>
diff --git a/pmd/rulesets/basic.xml b/pmd/rulesets/basic.xml
index 667ed7a705..fc956b4d30 100644
--- a/pmd/rulesets/basic.xml
+++ b/pmd/rulesets/basic.xml
@@ -1025,7 +1025,7 @@ public class Test {
 	    </description>
 	    <priority>3</priority>
 	     <properties>
-            <property name="pattern" description="Regular Expression" value="[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}"/>
+            <property name="pattern" description="Regular Expression" value='^"[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}"$'/>
         </properties>
 	    <example>
 	    <![CDATA[