From e2864fa85ad3f5bf12becb376d26dba4fc739eda Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Fri, 16 Jul 2021 09:58:17 +0200 Subject: [PATCH] Use LanguageVersion.compareToVersion MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Clément Fournier --- .../rule/performance/BigIntegerInstantiationRule.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/performance/BigIntegerInstantiationRule.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/performance/BigIntegerInstantiationRule.java index 4c2ef5213f..a1eb1d8a3f 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/performance/BigIntegerInstantiationRule.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/performance/BigIntegerInstantiationRule.java @@ -10,9 +10,7 @@ import java.util.Set; import org.checkerframework.checker.nullness.qual.NonNull; -import net.sourceforge.pmd.lang.LanguageRegistry; import net.sourceforge.pmd.lang.LanguageVersion; -import net.sourceforge.pmd.lang.java.JavaLanguageModule; import net.sourceforge.pmd.lang.java.ast.ASTArgumentList; import net.sourceforge.pmd.lang.java.ast.ASTConstructorCall; import net.sourceforge.pmd.lang.java.ast.ASTExpression; @@ -39,10 +37,8 @@ public class BigIntegerInstantiationRule extends AbstractJavaRulechainRule { @Override public Object visit(ASTConstructorCall node, Object data) { LanguageVersion languageVersion = node.getAstInfo().getLanguageVersion(); - boolean jdk15 = languageVersion - .compareTo(LanguageRegistry.getLanguage(JavaLanguageModule.NAME).getVersion("1.5")) >= 0; - boolean jdk9 = languageVersion - .compareTo(LanguageRegistry.getLanguage(JavaLanguageModule.NAME).getVersion("9")) >= 0; + boolean jdk15 = languageVersion.compareToVersion("1.5") >= 0; + boolean jdk9 = languageVersion.compareToVersion("9") >= 0; if (TypeTestUtil.isA(BigInteger.class, node) || jdk15 && TypeTestUtil.isA(BigDecimal.class, node)) {