From e2d28c80ee01af37bdc71d2fb1ed2a982984f150 Mon Sep 17 00:00:00 2001
From: Xavier Le Vourch <xlv@users.sourceforge.net>
Date: Wed, 18 Jun 2008 03:44:50 +0000
Subject: [PATCH] optimization of UnnecessaryBooleanAssertion, it was the
 second most expensive XPath rule, now almost twice as fast

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6228 51baf565-9d33-0410-a72c-fc3788e3496d
---
 pmd/rulesets/junit.xml | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/pmd/rulesets/junit.xml b/pmd/rulesets/junit.xml
index c86bc5d0b1..e9c1a97e31 100644
--- a/pmd/rulesets/junit.xml
+++ b/pmd/rulesets/junit.xml
@@ -168,18 +168,13 @@ statements like assertTrue(true) and assertFalse(false).  If you just want a tes
     <![CDATA[
 //StatementExpression
 [
-.//Name[@Image='assertTrue' or  @Image='assertFalse']
+PrimaryExpression/PrimaryPrefix/Name[@Image='assertTrue' or  @Image='assertFalse']
 and
-PrimaryExpression/PrimarySuffix/Arguments/ArgumentList
- /Expression/PrimaryExpression/PrimaryPrefix
-  /Literal/BooleanLiteral
+PrimaryExpression/PrimarySuffix/Arguments/ArgumentList/Expression
+[PrimaryExpression/PrimaryPrefix/Literal/BooleanLiteral
 or
-(
-.//Name[@Image='assertTrue' or  @Image='assertFalse']
-and
-PrimaryExpression/PrimarySuffix/Arguments/ArgumentList
- /Expression/UnaryExpressionNotPlusMinus[@Image='!']
-/PrimaryExpression/PrimaryPrefix[Literal/BooleanLiteral or Name[count(../../*)=1]])
+UnaryExpressionNotPlusMinus[@Image='!']
+/PrimaryExpression/PrimaryPrefix[Literal/BooleanLiteral or Name[count(../../*)=1]]]
 ]
 [ancestor::ClassOrInterfaceDeclaration[//ClassOrInterfaceType[typeof(@Image, 'junit.framework.TestCase','TestCase')] or //MarkerAnnotation/Name[typeof(@Image, 'org.junit.Test', 'Test')]]]
 ]]>