From f42be1425249e1f6fb410d9350ea2aa8e321febf Mon Sep 17 00:00:00 2001
From: Tom Copeland <tomcopeland@users.sourceforge.net>
Date: Tue, 31 Oct 2006 01:38:04 +0000
Subject: [PATCH] That's more like it

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4764 51baf565-9d33-0410-a72c-fc3788e3496d
---
 .../strictexception/ExceptionSignatureDeclaration.java     | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/pmd/src/net/sourceforge/pmd/rules/strictexception/ExceptionSignatureDeclaration.java b/pmd/src/net/sourceforge/pmd/rules/strictexception/ExceptionSignatureDeclaration.java
index 2c830bfd36..f1f9474510 100644
--- a/pmd/src/net/sourceforge/pmd/rules/strictexception/ExceptionSignatureDeclaration.java
+++ b/pmd/src/net/sourceforge/pmd/rules/strictexception/ExceptionSignatureDeclaration.java
@@ -44,7 +44,7 @@ public class ExceptionSignatureDeclaration extends AbstractRule {
         }
 
         List exceptionList = methodDeclaration.findChildrenOfType(ASTName.class);
-        if (!hasContent(exceptionList)) {
+        if (exceptionList.isEmpty()) {
             return super.visit(methodDeclaration, o);
         }
 
@@ -55,7 +55,7 @@ public class ExceptionSignatureDeclaration extends AbstractRule {
 
     public Object visit(ASTConstructorDeclaration constructorDeclaration, Object o) {
         List exceptionList = constructorDeclaration.findChildrenOfType(ASTName.class);
-        if (!hasContent(exceptionList)) {
+        if (exceptionList.isEmpty()) {
             return super.visit(constructorDeclaration, o);
         }
 
@@ -99,7 +99,4 @@ public class ExceptionSignatureDeclaration extends AbstractRule {
         return parent instanceof ASTMethodDeclaration || parent instanceof ASTConstructorDeclaration;
     }
 
-    private boolean hasContent(List nameList) {
-        return nameList != null && !nameList.isEmpty();
-    }
 }