From fdb54ecc0e309e67a6c6e015fe79b5157a274678 Mon Sep 17 00:00:00 2001
From: Andreas Dangel <adangel@users.sourceforge.net>
Date: Sat, 18 Apr 2015 18:21:11 +0200
Subject: [PATCH] #1337 False positive "Avoid throwing raw exception types"
 when exception is not thrown

---
 .../resources/rulesets/java/strictexception.xml     |  2 +-
 .../xml/AvoidThrowingRawExceptionTypes.xml          | 13 +++++++++++++
 src/site/markdown/overview/changelog.md             |  1 +
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/pmd-java/src/main/resources/rulesets/java/strictexception.xml b/pmd-java/src/main/resources/rulesets/java/strictexception.xml
index 43a0e8b589..703b6824a2 100644
--- a/pmd-java/src/main/resources/rulesets/java/strictexception.xml
+++ b/pmd-java/src/main/resources/rulesets/java/strictexception.xml
@@ -125,7 +125,7 @@ Exception, or Error, use a subclassed exception or error instead.
       <property name="xpath">
         <value>
             <![CDATA[
-//AllocationExpression
+//ThrowStatement//AllocationExpression
  /ClassOrInterfaceType[
  (@Image='Throwable' and count(//ImportDeclaration/Name[ends-with(@Image,'Throwable')]) = 0)
 or
diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/strictexception/xml/AvoidThrowingRawExceptionTypes.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/strictexception/xml/AvoidThrowingRawExceptionTypes.xml
index f57c8c7594..95d71e73ee 100644
--- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/strictexception/xml/AvoidThrowingRawExceptionTypes.xml
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/strictexception/xml/AvoidThrowingRawExceptionTypes.xml
@@ -40,4 +40,17 @@ public class PmdTest {
 }
      ]]></code>
     </test-code>
+    <test-code>
+        <description>#1337: False positive "Avoid throwing raw exception types" when exception is not thrown</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+public class PmdTest {
+    private Throwable cause;
+
+    public void setUp() {
+        cause = new Throwable();
+    }
+}
+]]></code>
+    </test-code>
 </test-data>
diff --git a/src/site/markdown/overview/changelog.md b/src/site/markdown/overview/changelog.md
index 80197a283f..003400b6df 100644
--- a/src/site/markdown/overview/changelog.md
+++ b/src/site/markdown/overview/changelog.md
@@ -16,6 +16,7 @@
 
 *   [#1332](https://sourceforge.net/p/pmd/bugs/1332/): False Positive: UnusedPrivateMethod
 *   [#1333](https://sourceforge.net/p/pmd/bugs/1333/): Error while processing Java file with Lambda expressions
+*   [#1337](https://sourceforge.net/p/pmd/bugs/1337/): False positive "Avoid throwing raw exception types" when exception is not thrown
 *   [#1338](https://sourceforge.net/p/pmd/bugs/1338/): The pmd-java8 POM bears the wrong parent module version
 
 **API Changes:**