From 8e1bad95481d9fdee1cc8416c40c93c7c58d7b8b Mon Sep 17 00:00:00 2001 From: aleksana Date: Fri, 31 May 2024 19:48:08 +0800 Subject: [PATCH 1/4] yubioath-flutter: pin to flutter 3.19 Unable to start with flutter 3.22. See https://github.com/NixOS/nixpkgs/issues/313292 --- pkgs/applications/misc/yubioath-flutter/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/misc/yubioath-flutter/default.nix b/pkgs/applications/misc/yubioath-flutter/default.nix index 0611655da1bc..da5cb37a978b 100644 --- a/pkgs/applications/misc/yubioath-flutter/default.nix +++ b/pkgs/applications/misc/yubioath-flutter/default.nix @@ -1,5 +1,5 @@ { lib -, flutter +, flutter319 , python3 , fetchFromGitHub , pcre2 @@ -11,7 +11,7 @@ , removeReferencesTo }: -flutter.buildFlutterApplication rec { +flutter319.buildFlutterApplication rec { pname = "yubioath-flutter"; version = "6.4.0"; From fa12dda70e9d544b846762bf63bd2c7abfbaccb2 Mon Sep 17 00:00:00 2001 From: aleksana Date: Fri, 31 May 2024 19:48:21 +0800 Subject: [PATCH 2/4] fluffychat: pin to flutter 3.19 Upstream still builds with flutter 3.19.6 in release 1.20.0, and I'm having graphical issues (black window on some pages) using flutter 3.22. --- .../networking/instant-messengers/fluffychat/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/networking/instant-messengers/fluffychat/default.nix b/pkgs/applications/networking/instant-messengers/fluffychat/default.nix index d2a43e989bb8..66d7abc0822d 100644 --- a/pkgs/applications/networking/instant-messengers/fluffychat/default.nix +++ b/pkgs/applications/networking/instant-messengers/fluffychat/default.nix @@ -4,7 +4,7 @@ , imagemagick , mesa , libdrm -, flutter +, flutter319 , pulseaudio , makeDesktopItem , gnome @@ -16,7 +16,7 @@ let libwebrtcRpath = lib.makeLibraryPath [ mesa libdrm ]; pubspecLock = lib.importJSON ./pubspec.lock.json; in -flutter.buildFlutterApplication (rec { +flutter319.buildFlutterApplication (rec { pname = "fluffychat-${targetFlutterPlatform}"; version = "1.20.0"; From 44f3630b91602f20bd7121c3cf49f1dcef38954d Mon Sep 17 00:00:00 2001 From: aleksana Date: Fri, 31 May 2024 19:48:55 +0800 Subject: [PATCH 3/4] flet-client-flutter: pin to flutter 3.19 Unable to start with flutter 3.22. See https://github.com/NixOS/nixpkgs/issues/313292 --- pkgs/by-name/fl/flet-client-flutter/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/fl/flet-client-flutter/package.nix b/pkgs/by-name/fl/flet-client-flutter/package.nix index 949e6f929575..73e714c8cfa5 100644 --- a/pkgs/by-name/fl/flet-client-flutter/package.nix +++ b/pkgs/by-name/fl/flet-client-flutter/package.nix @@ -1,7 +1,7 @@ { lib , fetchFromGitHub , pkg-config -, flutter +, flutter319 , gst_all_1 , libunwind , makeWrapper @@ -16,7 +16,7 @@ , flet-client-flutter }: -flutter.buildFlutterApplication rec { +flutter319.buildFlutterApplication rec { pname = "flet-client-flutter"; version = "0.22.1"; From 09fa054a4d62dece3715b9813f8f24fbce29566a Mon Sep 17 00:00:00 2001 From: aleksana Date: Fri, 31 May 2024 20:00:49 +0800 Subject: [PATCH 4/4] doc/dart: require to specify flutter version Context: @FlafyDev: I think flutter apps in nixpkgs should be required to specify a flutter version. like flutter319 and flutter322 instead of using flutter. https://github.com/NixOS/nixpkgs/pull/313711 --- doc/languages-frameworks/dart.section.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/languages-frameworks/dart.section.md b/doc/languages-frameworks/dart.section.md index 019765f75354..594ef7391cbb 100644 --- a/doc/languages-frameworks/dart.section.md +++ b/doc/languages-frameworks/dart.section.md @@ -98,10 +98,12 @@ The function `buildFlutterApplication` builds Flutter applications. See the [Dart documentation](#ssec-dart-applications) for more details on required files and arguments. +`flutter` in Nixpkgs always points to `flutterPackages.stable`, which is the latest packaged version. To avoid unforeseen breakage during upgrade, packages in Nixpkgs should use a specific flutter version, such as `flutter319` and `flutter322`, instead of using `flutter` directly. + ```nix { flutter, fetchFromGitHub }: -flutter.buildFlutterApplication { +flutter322.buildFlutterApplication { pname = "firmware-updater"; version = "0-unstable-2023-04-30";