From 2f2c0a6b02ee5db79df98a91d0bf071de1a9ffdc Mon Sep 17 00:00:00 2001 From: Mitchell Stokes Date: Mon, 25 Feb 2013 05:55:37 +0000 Subject: [PATCH] BGE: Fixing a crash reported by Ace Dragon on BA. It looks like Object->totcol can give a number higher than the number of materials, so I've added some NULL checks. --- source/gameengine/Ketsji/BL_Action.cpp | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/source/gameengine/Ketsji/BL_Action.cpp b/source/gameengine/Ketsji/BL_Action.cpp index ff1f800a626..1a49f76e71a 100644 --- a/source/gameengine/Ketsji/BL_Action.cpp +++ b/source/gameengine/Ketsji/BL_Action.cpp @@ -176,11 +176,13 @@ bool BL_Action::Play(const char* name, // Now try materials if (m_obj->GetBlenderObject()->totcol==1) { Material *mat = give_current_material(m_obj->GetBlenderObject(), 1); - sg_contr = BL_CreateMaterialIpo(m_action, mat, 0, m_obj, kxscene->GetSceneConverter()); - if (sg_contr) { - m_sg_contr_list.push_back(sg_contr); - m_obj->GetSGNode()->AddSGController(sg_contr); - sg_contr->SetObject(m_obj->GetSGNode()); + if (mat) { + sg_contr = BL_CreateMaterialIpo(m_action, mat, 0, m_obj, kxscene->GetSceneConverter()); + if (sg_contr) { + m_sg_contr_list.push_back(sg_contr); + m_obj->GetSGNode()->AddSGController(sg_contr); + sg_contr->SetObject(m_obj->GetSGNode()); + } } } else { Material *mat; @@ -188,12 +190,14 @@ bool BL_Action::Play(const char* name, for (int matidx = 1; matidx <= m_obj->GetBlenderObject()->totcol; ++matidx) { mat = give_current_material(m_obj->GetBlenderObject(), matidx); - matname = mat->id.name; - sg_contr = BL_CreateMaterialIpo(m_action, mat, matname.hash(), m_obj, kxscene->GetSceneConverter()); - if (sg_contr) { - m_sg_contr_list.push_back(sg_contr); - m_obj->GetSGNode()->AddSGController(sg_contr); - sg_contr->SetObject(m_obj->GetSGNode()); + if (mat) { + matname = mat->id.name; + sg_contr = BL_CreateMaterialIpo(m_action, mat, matname.hash(), m_obj, kxscene->GetSceneConverter()); + if (sg_contr) { + m_sg_contr_list.push_back(sg_contr); + m_obj->GetSGNode()->AddSGController(sg_contr); + sg_contr->SetObject(m_obj->GetSGNode()); + } } } }