From 569b7c28212b2c77ca4c6b530131de5fa8e73a95 Mon Sep 17 00:00:00 2001 From: Brecht Van Lommel Date: Thu, 29 Oct 2020 12:22:25 +0100 Subject: [PATCH] Cleanup: remove unused Blender Internal render stats code --- source/blender/editors/render/render_internal.c | 14 -------------- .../freestyle/intern/application/Controller.cpp | 7 +------ .../blender/render/extern/include/RE_pipeline.h | 1 - .../render/intern/source/external_engine.c | 2 -- source/blender/render/intern/source/initrender.c | 4 ---- source/blender/render/intern/source/pipeline.c | 16 +++++----------- 6 files changed, 6 insertions(+), 38 deletions(-) diff --git a/source/blender/editors/render/render_internal.c b/source/blender/editors/render/render_internal.c index 7ca711cd2b8..92bd2a137ef 100644 --- a/source/blender/editors/render/render_internal.c +++ b/source/blender/editors/render/render_internal.c @@ -435,20 +435,6 @@ static void make_renderinfo_string(const RenderStats *rs, } } else { - if (rs->totvert || rs->totface || rs->totlamp) { - spos += sprintf(spos, "| "); - } - - if (rs->totvert) { - spos += sprintf(spos, TIP_("Ve:%d "), rs->totvert); - } - if (rs->totface) { - spos += sprintf(spos, TIP_("Fa:%d "), rs->totface); - } - if (rs->totlamp) { - spos += sprintf(spos, TIP_("Li:%d "), rs->totlamp); - } - if (rs->mem_peak == 0.0f) { spos += sprintf(spos, TIP_("| Mem:%.2fM (Peak %.2fM) "), megs_used_memory, megs_peak_memory); } diff --git a/source/blender/freestyle/intern/application/Controller.cpp b/source/blender/freestyle/intern/application/Controller.cpp index 4628c76ca7f..0467e057642 100644 --- a/source/blender/freestyle/intern/application/Controller.cpp +++ b/source/blender/freestyle/intern/application/Controller.cpp @@ -927,12 +927,7 @@ Render *Controller::RenderStrokes(Render *re, bool render) float megs_used_memory = (mem_in_use) / (1024.0 * 1024.0); float megs_peak_memory = (peak_memory) / (1024.0 * 1024.0); - printf("%d objs, %d verts, %d faces, mem %.2fM (peak %.2fM)\n", - totmesh, - freestyle_render->i.totvert, - freestyle_render->i.totface, - megs_used_memory, - megs_peak_memory); + printf("%d objs, mem %.2fM (peak %.2fM)\n", totmesh, megs_used_memory, megs_peak_memory); } delete blenderRenderer; diff --git a/source/blender/render/extern/include/RE_pipeline.h b/source/blender/render/extern/include/RE_pipeline.h index 089c7eb044b..4dd2b300700 100644 --- a/source/blender/render/extern/include/RE_pipeline.h +++ b/source/blender/render/extern/include/RE_pipeline.h @@ -159,7 +159,6 @@ typedef struct RenderResult { typedef struct RenderStats { int cfra; - int totface, totvert, totlamp, totpart; bool localview; double starttime, lastframetime; const char *infostr, *statstr; diff --git a/source/blender/render/intern/source/external_engine.c b/source/blender/render/intern/source/external_engine.c index 440c54f5eeb..b2121816932 100644 --- a/source/blender/render/intern/source/external_engine.c +++ b/source/blender/render/intern/source/external_engine.c @@ -674,7 +674,6 @@ bool RE_bake_engine(Render *re, /* set render info */ re->i.cfra = re->scene->r.cfra; BLI_strncpy(re->i.scene_name, re->scene->id.name + 2, sizeof(re->i.scene_name) - 2); - re->i.totface = re->i.totvert = re->i.totlamp = 0; /* render */ engine = re->engine; @@ -812,7 +811,6 @@ int RE_engine_render(Render *re, int do_all) /* set render info */ re->i.cfra = re->scene->r.cfra; BLI_strncpy(re->i.scene_name, re->scene->id.name + 2, sizeof(re->i.scene_name)); - re->i.totface = re->i.totvert = re->i.totlamp = 0; /* render */ engine = re->engine; diff --git a/source/blender/render/intern/source/initrender.c b/source/blender/render/intern/source/initrender.c index d1632dfeacd..7eeef79e527 100644 --- a/source/blender/render/intern/source/initrender.c +++ b/source/blender/render/intern/source/initrender.c @@ -268,9 +268,6 @@ void RE_parts_init(Render *re) re->parts = BLI_ghash_new( BLI_ghashutil_inthash_v4_p, BLI_ghashutil_inthash_v4_cmp, "render parts"); - /* this is render info for caller, is not reset when parts are freed! */ - re->i.totpart = 0; - /* just for readable code.. */ xminb = re->disprect.xmin; yminb = re->disprect.ymin; @@ -328,7 +325,6 @@ void RE_parts_init(Render *re) pa->recty = recty; BLI_ghash_insert(re->parts, &pa->disprect, pa); - re->i.totpart++; } } } diff --git a/source/blender/render/intern/source/pipeline.c b/source/blender/render/intern/source/pipeline.c index 917193553dc..14375c27bfa 100644 --- a/source/blender/render/intern/source/pipeline.c +++ b/source/blender/render/intern/source/pipeline.c @@ -188,6 +188,10 @@ static int default_break(void *UNUSED(arg)) static void stats_background(void *UNUSED(arg), RenderStats *rs) { + if (rs->infostr == NULL) { + return; + } + uintptr_t mem_in_use, peak_memory; float megs_used_memory, megs_peak_memory; char info_time_str[32]; @@ -208,17 +212,7 @@ static void stats_background(void *UNUSED(arg), RenderStats *rs) info_time_str, sizeof(info_time_str), PIL_check_seconds_timer() - rs->starttime); fprintf(stdout, TIP_("| Time:%s | "), info_time_str); - if (rs->infostr) { - fprintf(stdout, "%s", rs->infostr); - } - else { - fprintf(stdout, - TIP_("Sce: %s Ve:%d Fa:%d La:%d"), - rs->scene_name, - rs->totvert, - rs->totface, - rs->totlamp); - } + fprintf(stdout, "%s", rs->infostr); /* Flush stdout to be sure python callbacks are printing stuff after blender. */ fflush(stdout);