ligang/vpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lldp: protection code to check a valid interface index

Browse Source 
When lldp interface is set, it's better to check valid interface index.

Change-Id: I0db0ab6483ad73d28c69893576aa9b719c3b087c
Signed-off-by: Steve Shin <jonshin@cisco.com>
This commit is contained in:
Steve Shin
2017-10-25 11:16:45 -07:00
committed by John Lo
parent 6476b3c148
commit cda4c88de7
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/vnet/lldp/lldp_cli.c
View File

@@ -49,9 +49,16 @@ lldp_cfg_intf_set (u32 hw_if_index, u8 ** port_desc, u8 ** mgmt_ip4,
lldp_main_t *lm = &lldp_main;
vnet_main_t *vnm = lm->vnet_main;
ethernet_main_t *em = &ethernet_main;
const vnet_hw_interface_t *hi = vnet_get_hw_interface (vnm, hw_if_index);
const ethernet_interface_t *eif = ethernet_get_interface (em, hw_if_index);
const vnet_hw_interface_t *hi;
const ethernet_interface_t *eif;
if (pool_is_free_index (vnm->interface_main.hw_interfaces, hw_if_index))
{
return lldp_invalid_arg;
}
hi = vnet_get_hw_interface (vnm, hw_if_index);
eif = ethernet_get_interface (em, hw_if_index);
if (!eif)
{
return lldp_not_supported;