From d5b7840245cb39a6a031e7d4f7bc04f2afb049a0 Mon Sep 17 00:00:00 2001 From: Andrew Yourtchenko Date: Thu, 3 Oct 2019 07:55:52 +0000 Subject: [PATCH] acl: fix intermittent test failure ACL tests use random port number in the tests. A port number 6081 causes the decode in scapy to consume some of the Raw payload into GENEVE encoding, which breaks the test. Solution: bring up the lower range of random port to 16384, so that it does not touch any of the well known ports. Type: test Change-Id: I022660d8ec147857924b436f1871b0b5ddcf4c47 Signed-off-by: Andrew Yourtchenko (cherry picked from commit ec574ff9129a7cc4282916d2a989e88d78aaff60) --- src/plugins/acl/test/test_acl_plugin.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/plugins/acl/test/test_acl_plugin.py b/src/plugins/acl/test/test_acl_plugin.py index eca02316bf6..91f5ef0ec8e 100644 --- a/src/plugins/acl/test/test_acl_plugin.py +++ b/src/plugins/acl/test/test_acl_plugin.py @@ -992,7 +992,7 @@ class TestACLplugin(VppTestCase): """ self.logger.info("ACLP_TEST_START_0015") - port = random.randint(0, 65535) + port = random.randint(16384, 65535) # Add an ACL rules = [] rules.append(self.create_rule(self.IPV4, self.PERMIT, port, @@ -1014,7 +1014,7 @@ class TestACLplugin(VppTestCase): """ self.logger.info("ACLP_TEST_START_0016") - port = random.randint(0, 65535) + port = random.randint(16384, 65535) # Add an ACL rules = [] rules.append(self.create_rule(self.IPV4, self.PERMIT, port, @@ -1036,7 +1036,7 @@ class TestACLplugin(VppTestCase): """ self.logger.info("ACLP_TEST_START_0017") - port = random.randint(0, 65535) + port = random.randint(16384, 65535) # Add an ACL rules = [] rules.append(self.create_rule(self.IPV6, self.PERMIT, port, @@ -1058,7 +1058,7 @@ class TestACLplugin(VppTestCase): """ self.logger.info("ACLP_TEST_START_0018") - port = random.randint(0, 65535) + port = random.randint(16384, 65535) # Add an ACL rules = [] rules.append(self.create_rule(self.IPV6, self.PERMIT, port, @@ -1081,7 +1081,7 @@ class TestACLplugin(VppTestCase): """ self.logger.info("ACLP_TEST_START_0019") - port = random.randint(0, 65535) + port = random.randint(16384, 65535) # Add an ACL rules = [] rules.append(self.create_rule(self.IPV4, self.DENY, port, @@ -1108,7 +1108,7 @@ class TestACLplugin(VppTestCase): """ self.logger.info("ACLP_TEST_START_0020") - port = random.randint(0, 65535) + port = random.randint(16384, 65535) # Add an ACL rules = [] rules.append(self.create_rule(self.IPV4, self.DENY, port, @@ -1136,7 +1136,7 @@ class TestACLplugin(VppTestCase): """ self.logger.info("ACLP_TEST_START_0021") - port = random.randint(0, 65535) + port = random.randint(16384, 65535) # Add an ACL rules = [] rules.append(self.create_rule(self.IPV4, self.DENY, port, @@ -1162,7 +1162,7 @@ class TestACLplugin(VppTestCase): """ VPP-687 zero length udp ipv4 packet""" self.logger.info("ACLP_TEST_START_0022") - port = random.randint(0, 65535) + port = random.randint(16384, 65535) # Add an ACL rules = [] rules.append(self.create_rule(self.IPV4, self.PERMIT, port, @@ -1197,7 +1197,7 @@ class TestACLplugin(VppTestCase): """ VPP-687 zero length udp ipv6 packet""" self.logger.info("ACLP_TEST_START_0023") - port = random.randint(0, 65535) + port = random.randint(16384, 65535) # Add an ACL rules = [] rules.append(self.create_rule(self.IPV6, self.PERMIT, port,