From fb0cbc64e64a53e495662128457f4673b8760e03 Mon Sep 17 00:00:00 2001 From: Adrian Villin Date: Thu, 12 Dec 2024 09:16:22 +0100 Subject: [PATCH] hs-test: fix a runtime error - framework panicked if core_pattern was set to "core" Type: test Change-Id: I14211cc59779090a61e6e08a18d16fd7399b2bed Signed-off-by: Adrian Villin --- extras/hs-test/infra/container.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/extras/hs-test/infra/container.go b/extras/hs-test/infra/container.go index f6ccd88e118..6605c866939 100644 --- a/extras/hs-test/infra/container.go +++ b/extras/hs-test/infra/container.go @@ -331,8 +331,12 @@ func (c *Container) getVolumesAsSlice() []string { if err == nil { if len(core_pattern) > 0 && core_pattern[0] != '|' { index := strings.LastIndex(core_pattern, "/") - core_pattern = core_pattern[:index] - volumeSlice = append(volumeSlice, c.Suite.getLogDirPath()+":"+core_pattern) + if index == -1 { + c.Suite.Log("'core_pattern' isn't set to an absolute path. Core dump check will not work.") + } else { + core_pattern = core_pattern[:index] + volumeSlice = append(volumeSlice, c.Suite.getLogDirPath()+":"+core_pattern) + } } else { c.Suite.Log(fmt.Sprintf("core_pattern \"%s\" starts with pipe, ignoring", core_pattern)) }