Commit Graph

7635 Commits

Author SHA1 Message Date
Jakub Grajciar
1a7bb281f5 avf: improve timeout handling
Type: feature

Change-Id: I8fa1d691ef7bc51ae5c44c344195207ce7d0a2e7
Signed-off-by: Damjan Marion <damarion@cisco.com>
2019-10-23 11:53:01 +00:00
Ignas Bačius
eeb5fb3a50 sr: add "set sr encaps hop-limit" command
Default hop-limit for the encapsulating IPv6 header is a compile-time
constant. Add ability to specify custom hop-limit, in order to avoid
packets being dropped with "hop limit exceeded in transit" response in
certain network configurations.

Type: feature
Signed-off-by: Ignas Bačius <ignas@noia.network>
Change-Id: I77f2b35c987cfd31801dc2744d31fb3c1984158f
2019-10-23 07:52:22 +00:00
Miklos Tirpak
bd0a00a456 gtpu: msg id fix in send_gtpu_tunnel_details api
Type: fix

_vl_msg_id must start at msg_id_base.

Signed-off-by: Miklos Tirpak <miklos.tirpak@gmail.com>
Change-Id: Id3f05683c873fcac47667a9736e45e85849b740c
2019-10-23 07:51:42 +00:00
Ole Troan
40dc4b35e3 papi: fix default handling
The BaseTypers object were reused, so a default for anyother mesage
would be inherited in new messages.

Type: fix
Fixes: 85465588b1
Change-Id: Ie1efb85a76b088653eb9ea4b88540c98b6b0aad0
Signed-off-by: Ole Troan <ot@cisco.com>
2019-10-23 07:47:19 +00:00
Florin Coras
d6ae4bf13a tcp: improve rate samples for retansmitted segments
Type: fix

- Initialize max_seq on both transmitted and retransmitted segments
- Keep track of segments that have been sacked.
- Track new data segments sent during recovery

Change-Id: Ice55231a3da200ae6171702e54b2ce155f831143
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-10-23 07:46:33 +00:00
Florin Coras
81cb8e4092 tcp: fix sack retransmit beyond snd_nxt
Type: fix

Ensure that sack retransmit logic does not try to inadvertently send new
data.

Change-Id: Idfda19643577d9c1b58e2af8d8283cabfbaf98e6
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-10-23 07:45:00 +00:00
Benoît Ganne
386ebb6e2b rdma: build: fix ibverb compilation test
Type: fix

Change-Id: Ib6389ecbcf4a1b7bae25b2bd9e7fbdec49545aaa
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-10-23 07:43:25 +00:00
Benoît Ganne
70d5d4fa09 vppinfra: make coverity happy with vec_set_len
Coverity gets confused by ASSERT((l) <= vec_max_len(v)) when l is 0.

Type: fix

Change-Id: I247d7015b148233d8f195bcf41e9a047b7a21309
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-10-22 18:17:27 +00:00
Dave Wallace
3ad078d75d tests: quic add big stream extended tests
Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I6c5bdfd934a2c96c410c36c2bc090ee47b679bea
2019-10-22 18:07:17 +00:00
haiyanx1.zhang
419d31f817 tests: test tls case
Type: feature

Signed-off-by: haiyanx1.zhang <haiyanx1.zhang@intel.com>
Change-Id: I071f5face0d489dc967cce1edcffbc1f8fac5c7e
Signed-off-by: haiyanx1.zhang <haiyanx1.zhang@intel.com>
2019-10-22 17:13:21 +00:00
Florin Coras
dbc9c599b9 vcl: handle segment map errors
Type: fix

Change-Id: Ibd122a4565c067627c4bbc8cac7df2d5b6497392
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-10-22 17:03:23 +00:00
Florin Coras
d747c3c362 vcl: add config option for preferred tls engine
Type: feature

Change-Id: If6c095c9b737cb524a9232dcfa9be0f93f04d114
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-10-22 16:58:43 +00:00
Dave Wallace
91af1859da tests: enable vpp_echo to run in gdb
- Enable vpp_echo to be run in gdb when
  running 'make test DEBUG=gdb-all'

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I79a69b0573c01900535078d7493d52b417350815
2019-10-22 16:31:03 +00:00
Dave Wallace
2456433df4 tests: DEBUG=gdb[server]-all to debug worker(s)
Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I0264451632c1ce780b38a2c15a7e34350fc6d521
2019-10-22 16:30:51 +00:00
Benoît Ganne
78af0a8c5f vppinfra: add clib_mem_free_s
IPsec zero-es all allocated key memory including memory sur-allocated by
the allocator.
Move it to its own function in clib mem infra to make it easier to
instrument.

Type: refactor

Change-Id: Icd1c44d18b741e723864abce75ac93e2eff74b61
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-10-22 14:06:15 +00:00
Filip Tehlar
c41217ab85 ikev2: fix GCM cipher
Type: fix

Change-Id: I382499061ff4b1c2cc1b70ebbf9725ff0e1be325
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2019-10-22 14:05:04 +00:00
Klement Sekera
c9b2cfca9a ip: reassembly: avoid corruption in vnet buffer
Avoid corrupt next_index in vnet_buffer by moving input and output
variables into different memory places instead of sharing a common
space.

Type: fix
Fixes: de34c35fc7

Change-Id: I34471fc6d0c8487535fac21349e688f398934f6d
Signed-off-by: Klement Sekera <ksekera@cisco.com>
2019-10-22 13:55:21 +00:00
Neale Ranns
bb098f1764 gbp: missing contract hash-mode setting
Type: fix

Change-Id: Ia0f1e88b43e861d3f6965076c73cc48fb9574da3
Signed-off-by: Neale Ranns <nranns@cisco.com>
2019-10-22 13:52:31 +00:00
Filip Tehlar
89b2495000 ipsec: fix tunnel protection removal
Type: fix

Change-Id: I4d5546d1f9b3a162291997f6f0c094c5c3d6cf31
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2019-10-18 22:24:41 +00:00
Jakub Grajciar
2f71a88899 ip: ipfix-export API update
Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I5b03e5de111c3a3b8da4e9f02cba0aa99e3ee9f3
2019-10-22 09:09:58 +00:00
Ole Troan
bd38f7ff8c cdp: disable failing tests for python3
scapy in python3 does not seem to allow creating invalid protocol
packets. Suggest the maintainer rewrite the invalid tests so they
also work for python3. In the mean time they are disabled.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I554d57528422c98c6df4ba76eeae38c03f512a38
2019-10-22 08:15:09 +00:00
Benoît Ganne
534de8b2a7 build: add missing ldflags to exe and shared
Type: fix

Change-Id: I859bc6ebc574ab09fd70b45f8c911769d00e7acf
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-10-22 08:15:01 +00:00
Benoît Ganne
8a4bfdae87 vppinfra: add vec_set_len()
l2-flood and bier nodes reset vector length without updating it to its
effective size. Introduce a helper to do it (this allows ASAN to keep
track of the new vector size).

Type: refactor

Change-Id: I2d652550c440f0553a2b49c3ee3d37b49ebc16c3
Signed-off-by: Benoît Ganne <bganne@cisco.com>
2019-10-22 08:14:26 +00:00
snaramre
26ea1465ae tests: python3 changes for dns tests
Type: fix
Change-Id: Ia81c60d469b29606d9988d7d9ed1e133e6af7158
Signed-off-by: snaramre <snaramre@cisco.com>
2019-10-22 07:39:53 +00:00
Ole Troan
b0d83f188d flowprobe: tests support python3
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I7425147e864467e4f94cee2a82ef74a894339471
2019-10-22 07:39:23 +00:00
Yu Ping
98bd35808d tls: enable tls engine as the default engine
OpenSSL TLS is well maintained and many issues are fixed, and it makes
OpenSSL as the default engine will be more friendly to users if app does
not configure a specific engine such as http_static

Type: fix

Change-Id: I37499af1edd40ffb53b00436044d1fce3b43348d
Signed-off-by: Yu Ping <ping.yu@intel.com>
2019-10-21 23:33:47 +00:00
Ole Troan
6769473303 geneve: tests support python3
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I0ff4d58c181b2bdf483b8b039ad005c2a4915aa8
2019-10-21 20:55:52 +00:00
Ole Troan
f6dee6c8ba bonding: tests support python3
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I6cedb43af4437fdabce75f4a845629c5c2f96f6a
2019-10-21 20:53:14 +00:00
Ole Troan
5e56f7511c ip: test support python3
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I9c66bce900f78e5fbd435515df94e327ad25c3c6
2019-10-21 20:00:50 +00:00
Ole Troan
3f2a956a44 l2: tests support python3
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id17bcb65d7eb27f865fc7872b3e485c09f1d29a7
2019-10-21 19:53:30 +00:00
Ole Troan
203bf04d46 acl: l2 classify test support python3
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3b2e57e3dcf04ae50724b5909272b083d6003a85
2019-10-21 19:53:18 +00:00
Ole Troan
8b76c23d57 ipsec: tests support python3
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id13da9371c71c10c12a0120ec89ba21c1ca47524
2019-10-21 20:55:13 +02:00
Ole Troan
1556b3ad7d classify: tests to support python3
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8af6ee6e5239f0836978baa063a18a01c610279f
2019-10-21 18:32:58 +00:00
Ole Troan
2267429574 bier: tests support python3
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3cf5295f1a85579a66ba38ca1f74678b45474959
2019-10-21 17:55:13 +00:00
Mathias Raoul
74dcbf97af quic: Add PICOTLS_INCLUDE_DIR var to CMakeLists.
Type: fix

Change-Id: I10ebcc653491d11ca798e0a60be6eeef82c41766
Signed-off-by: Mathias Raoul <mathias.raoul@gmail.com>
2019-10-21 15:57:52 +00:00
Andrew Yourtchenko
586d3edf49 tests: add PID of VPP under test to API dump filename for the test
Some testclasses (e.g. IPSec) have methods with the same names,
this causes a race when running in parallel to save the API and
move it into the test's directory - the name of the file has
only the test method name as a discriminator.

Saving two traces from two VPP instances "succeeds", in that
it silently overwrites the file. But only one mv operation
works - the other gives an error "file not found" and fails the test.

Solution: add the PID of VPP under test to the API dump filename,
this way the filenames become guaranteed unique and the race is avoided.

Change-Id: I1bb47ed73369fea0f1bfbf907588a51e2cabfb7f
Type: test
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2019-10-21 12:55:48 +00:00
Ole Troan
127fbec4d3 ip: reassembly tests python3 support
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I990d8d521c128e8d4f482e30b3a49cbc11b632d1
2019-10-21 10:51:00 +00:00
Florin Coras
79ba25d402 session: support registration of custom crypto engines
Type: feature

Change-Id: I888d415ff645b3827df7d4cfb0d3c5f4ac940617
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-10-21 10:46:09 +00:00
Florin Coras
ef7cbf6adf vcl: add api to set lcl ip
Type: feature

Change-Id: I40169fbbe8a20670dd612c341b6c78b5c925bf74
Signed-off-by: Florin Coras <fcoras@cisco.com>
2019-10-21 10:43:54 +00:00
Ole Troan
12966a7a0a dhcp: python3 support in tests
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ie136c1e94e5c25f9547fc2d6d45ce8e1630a035c
2019-10-21 10:02:01 +00:00
Yulong Pei
45495480c8 vlib: linux: fix wrong iommu_group value issue when using dpdk-plugin
When VPP work with dpdk-plugin, linux_vfio_main_t->container_fd is always -1
since it never have chance to run open("/dev/vfio/vfio") to get the fd.

But this lead to a potential issue of VPP, that is, when start VPP without
uio-driver field setup in /etc/vpp/startup.conf, VPP will run to automatical
select uio driver in vlib_pci_bind_to_uio() and the function depend on
iommu_group value to decide to work on vfio or vfio-noiommu mode.

Since in vlib_pci_get_device_info() have the condition container_fd != -1,
so the iommu_group value will be always -1 at this scenario, this caused
that VPP mistake to run with vfio-noiommu driver on intel_iommu=on state.

Actually in order to get iommu_group and iommu_group/name value, no need to
depend on linux_vfio_main_t->container_fd value, so the fix remove the
condition lvm->container_fd != -1, then it can get the correct iommu_group
value.

Type: fix

Change-Id: I3f162fc4971b9a2b8717205f8f3b52e30c5e5b69
Signed-off-by: Yulong Pei <yulong.pei@intel.com>
2019-10-20 19:31:14 +00:00
Dave Barach
349cd1af77 vlib: enable worker-thread dispatch pcap trace
Needed a bit of foreach_vlib_main(...) action to turn on/off all
instances of vm->dispatch_pcap_enable, and to pick up the pcap_main_t
pointer from vlib_global_main.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I49b69b87934c7dc7a9835cd07aa2c5c4d3c79f18
2019-10-18 14:44:34 -04:00
Dave Barach
55cc4c4f0a mactime: fix handle_get_mactime fcn prototype
Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I9576ade941b10d1605f6c6714f312ae2a8ad5065
2019-10-18 11:36:17 -04:00
Ole Troan
9cd8f33979 ip: add python3 support to punt tests
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ib918d11fb3278a25a92006dcfe3c7c484e7b33ea
2019-10-18 15:00:55 +00:00
Ole Troan
9e160f82be map: python3 support in tests
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Icbe9ca3dc738c6575fe382740a1cc9d29a4a74ff
2019-10-18 14:24:48 +00:00
Ole Troan
2915649f29 gso: python3 support in tests
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I166019cc69fd01cb43f1a3fad699f3d2e5ec5b19
2019-10-18 14:24:25 +00:00
Ole Troan
197573320d ip: ip vrf tests python3 support
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ie23c9d2d7325be62ef33df2f0562ab41518f7bf4
2019-10-18 13:44:32 +00:00
Ole Troan
5dc5fcf14c udp:: support python3 in tests
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Iea19d7bc2dfe9736ddefb4419509ccfda7a67eeb
2019-10-18 14:40:54 +02:00
Ole Troan
e5b83aa3eb memif: add python3 support to test
Committed from SK936 seat 1A.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I717fafbdb9b8576508d6dd72a7e5653cecebfae0
Signed-off-by: Ole Troan <ot@cisco.com>
2019-10-18 11:53:32 +00:00
Paul Vinciguerra
f158944cc4 ip: trivial typos in docs
Type: style

Change-Id: I620f15b96ee5401e0145a139f06d343d7c4fadb4
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2019-10-18 10:54:37 +00:00