Commit Graph

8410 Commits

Author SHA1 Message Date
Damjan Marion
47d8f5dcd6 crypto-native: GCM implementation with vector AESNI instructions
Introduced on intel IceLake uarch.

Type: feature
Change-Id: I1514c76c34e53ce0577666caf32a50f95eb6548f
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-02-25 11:51:48 +01:00
Neale Ranns
8d6d74cdf4 vlib: Punt reason allocation listener enable/disable callback
Type: improvement

allow clients that allocate punt reasons to pass a callback function
that is invoked when the first/last client registers to use/listen on
that punt reason. This allows the client to perform some necessary
configs that might not otherwise be enabled.
IPSec uses this callback to register the ESP proto and UDP handling
nodes, that would not otherwise be enabled unless a tunnel was present.

Change-Id: I9759349903f21ffeeb253d4271e619e6bf46054b
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-02-25 10:48:52 +00:00
Filip Tehlar
719ef39d98 crypto: fix coverity warnings
Type: fix

Change-Id: I89c0923ad6ac1daf65b2d24ad4b6f00b7703e58e
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2020-02-25 10:45:41 +00:00
Filip Tehlar
41e831f558 crypto-openssl: fix coverity warnings
Type: fix

Change-Id: Ia42ff39a0a33f89901b8333a9e6ca82ca9805cc6
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2020-02-25 10:44:46 +00:00
Filip Tehlar
ba46770636 ikev2: add retry logic for session initiation
Type: improvement

Change-Id: Ib474dabb745bc2034d8d60261c095e35a8fff277
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2020-02-25 09:17:30 +00:00
Florin Coras
a9d8cb494f tcp: dynamic max timers per loop
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If0a634c277d4f8e4d32321f52253721a990bdb1d
2020-02-24 21:30:51 +00:00
Damjan Marion
2bcf86f485 crypto-native: introduce aes_gcm_flags_t
Type: refactor
Change-Id: I53b4a9c0b63e6e6c6a13c33c5baa4c3de562584b
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-02-24 19:14:54 +01:00
Damjan Marion
52eea642c5 crypto-native: introduce counter struct
Type: refactor
Change-Id: I9ecc18ba3ec5f11622ea225690fb1dc262ea6fc1
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-02-24 15:58:02 +00:00
Neale Ranns
1103c8c04a vlib: Alias RX or TX to direction
Type: improvement

for those that find that name usefull.

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I6c99bcdbb10ca1615aeea6924c2d93a68b5b7684
2020-02-24 15:47:53 +00:00
Dave Barach
6e495ce428 vppinfra: correct fixed pool header size calculation
Remove duplicate space allocation for the pool header. Not significant
w/ CLIB_CACHE_LINE_BYTES >= 64 since the code rounds the size of the
pool header to an even multiple of the cache line size.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I923f2a60e7565cf2dfbc18d78264bf82ff30c926
2020-02-24 15:47:07 +00:00
Neale Ranns
e98d71b07e ethernet: trivial additions
Type: improvement

- macros to identify SENDER and TARGET in ARP header
- count the number of bits set in a mac_address

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Id31e27a4f5f01a8cfb70d3798416bb2519981654
2020-02-24 15:46:37 +00:00
Neale Ranns
f0d8d8fca9 l2: remove unused types and includes form feature arc code
Type: improvement

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Ia441c069afe79ccd6428159df944d4c1d10a992d
2020-02-24 15:45:24 +00:00
Filip Tehlar
c8e19cba7e ikev2: proper cleanup of SAs during rekey
Type: fix

Change-Id: Ifb675c7783f03de4db8147858dd93d9687176f40
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2020-02-24 15:26:53 +00:00
Damjan Marion
a2e56ee4d8 crypto-native: inverse Hi so it naturally fits into 512-bit register
Type: refactor
Change-Id: I0c6ca9356af179abd0a414b356dea7e3a3eb0dd6
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-02-24 14:29:54 +01:00
Damjan Marion
bc50a66514 crypto-native: replace aesni with aes
This code also works on ARM so let's not use intel term....

Type: refactor

Change-Id: Ie51d4359a83f2bf7a61c4861d486b7d009fc8057
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-02-24 14:17:57 +01:00
Damjan Marion
2e9a06fa60 crypto-native: do not overwrite data after partial tag
Type: fix

Change-Id: I01de5f8813faff5406ccf67c21c42393c8648af6
Signed-off-by: Damjan Marion <damarion@cisco.com>
2020-02-24 14:13:27 +01:00
Florin Coras
e9570d4ee3 session: include timer generated packets in max burst
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ic9174c92ab05b58e62b00999fe9cbf4e9292d43e
2020-02-23 19:00:18 +00:00
Florin Coras
aaf64a263f session: minimize number of tx events
Type: improvement

Unset fifo tx event only if all data has been dequeued. Avoids frequent
re-scheduling of sessions as new sessions.

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I36a4c90b97e0255b88782032fb029640e6a73e90
2020-02-23 18:47:29 +00:00
Dave Barach
2fef3dfa5c vppinfra: deprecate CLIB_VEC64
Type: refactor
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Id1e7c0926036db4601c91438397ceed22381fc07
2020-02-23 17:48:53 +00:00
Simon Zhang
487507f40f tcp: remove useless prediction
Type: fix

Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: Ie2dc2653baec92347eb2cbcd197a2e5ec6a80c79
2020-02-22 13:24:40 +00:00
Filip Tehlar
b05249b3b4 ikev2: cleanup tunnels after subsequent sa-init
Type: fix

Change-Id: I44e51bc37ff43999290d97fceb5f94b7c64041ec
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2020-02-21 09:56:02 +00:00
Neale Ranns
e9a630a524 gbp: Coverity warnings for unitialized variables
Type: fix

Change-Id: If74ad528e68f45b00719295388e0e1399452ef93
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-02-21 09:55:34 +00:00
Neale Ranns
ea96e92361 fib: Uninitialised pad in the prefix (coverity warning)
Type: fix

Change-Id: Ia61d6fbf6e80977f83f1f6672e5e83b52ddeb0e5
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-02-21 09:55:19 +00:00
Neale Ranns
282872127b ipsec: IPSec protection for multi-point tunnel interfaces
Type: feature

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Iaba2ab11bfaa1c8db4023434e3043ac39500f938
2020-02-21 09:54:19 +00:00
Neale Ranns
d057625d49 ipip: Unintialized return variable (coverity warning)
Type: fix

Change-Id: I008f23b5f0c7269ddd35cc747a867240fbe9c49b
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-02-21 09:53:21 +00:00
Neale Ranns
39a233a0aa ip: Unintialized variables in prefx setup (coverity warning)
Type: fix

Change-Id: I048c9ed423ca2993d2179cdce364ac98980311bb
Signed-off-by: Neale Ranns <nranns@cisco.com>
2020-02-21 09:53:00 +00:00
Dave Barach
d1586962a5 dhcp: update secondary radv_info structures
For details, see the Jira ticket below. Fix gerrit 23350.

Type: fix
Fixes: 28a6eb7
Ticket: VPP-1840

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ic9248734bb330eadb302f8410e8db9c64723f075
2020-02-21 09:52:42 +00:00
Matthew Smith
269549491a vrrp: fix coverity errors
Type: fix
Fixes: 39e9428b90

Fix warnings about potential problems with an implicit type cast
and a null pointer dereference.

Change-Id: I8c8d220e79ba45b62ba783cfe53cb49eef175fc8
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
2020-02-21 08:53:57 +00:00
Florin Coras
62a7fe2893 tcp: fix coverity warning in bt
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I4153a9a377b8b1da1366a94ff791ad99617b7a6d
2020-02-20 17:49:16 +00:00
Florin Coras
6ce954f8e4 lisp: fix coverity warnings
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ie060b25b5e8c85d9b2037e300723a2b6023c65d1
2020-02-20 17:48:46 +00:00
Dave Wallace
f58571ee6f hsa: cleanup vpp_echo JSON output
- Fix invalid json syntax
- Add bits_per_second rx/tx fields

Type: fix

Change-Id: I4100245b01093e99a6c7def16cd83572ab033e24
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2020-02-20 16:56:27 +00:00
Florin Coras
dd989487a6 dpdk: rx checksum offload
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I5a3e3a41dcc60c0d9b291e51bb112e7701f73050
2020-02-20 15:55:22 +00:00
Neale Ranns
3ebebc3a2f fib: adjacency midchain teardown (VPP-1841)
Type: fix

Change-Id: I57f8bfbce4feed9d2775875cb8b1b729a47900a4
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit 24064d02aa)
2020-02-20 14:01:47 +00:00
Filip Varga
98301bd560 nat: user deletion function & extra metrics
Type: improvement

Signed-off-by: Filip Varga <fivarga@cisco.com>
Change-Id: Ia5dbfe864c18e953ff49147a9a4684d2ca14b96e
2020-02-20 09:29:41 +00:00
Vladimir Isaev
1284f8c71d ip-neighbor: Fix aging timeout
Before this patch VPP checked age for ARP/NDP records every 1e5 seconds
for any configured aging time. This is 27 hours and it looks like
misprint because 1e5 is the number of 10us ticks in a second.

Also time to wait is now difference between aging time and time alive
for nodes in alive state.

Type: fix
Signed-off-by: Vladimir Isaev <visaev@netgate.com>
Change-Id: Ib5baa85032a44402d5f48c1145245260a42c7bae
2020-02-20 09:12:52 +00:00
Alexander Chernavin
f145c15631 map: honor pre-resolve param in map-t
With this commit, forward the translated packet directly to the
specified next-hop if pre-resolve param is enabled in MAP-T.

Type: fix

Change-Id: Ie26080c7820318c7982599577a4af6e4d01a0574
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
2020-02-20 09:04:26 +00:00
Alexander Chernavin
b728a3c8b7 map: honor icmp6-unreachables param in map-t
With this commit, send ICMPv6 unreachable messages back if security
check fails and icmp6-unreachables param enabled in MAP-T.

Type: fix

Change-Id: I9a8869df7763c764a1672e3faa1fde8dc13ec85a
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
2020-02-20 09:03:34 +00:00
Klement Sekera
8a10c7351b nat: avoid running pointless session cleanups
Save the next session timeout when sweeping sessions for cleanup so that
we can avoid unnecessary runs of the sweeping algorithm.

Type: fix
Change-Id: I736d00f2dfe242af10f963fbe34b11128f8b0613
Signed-off-by: Klement Sekera <ksekera@cisco.com>
2020-02-20 08:49:28 +00:00
Filip Varga
855938073f nat: nat44 split slow and fast path
Type: improvement

Change-Id: I07c7e1c154583906ac9af958f22ed9a1be382f4a
Signed-off-by: Filip Varga <fivarga@cisco.com>
2020-02-20 08:48:35 +00:00
Filip Tehlar
d3884202a7 ikev2: fix logging init
Type: fix

Change-Id: I76bed5ce2df897d0e8e822ee1244018b0e39494d
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2020-02-20 08:37:18 +00:00
Neale Ranns
a434955b33 fib: fib path realloc during midchain stack
Type: fix

Change-Id: I0677f46dfa22c8abab7f311230a09ef1cd8ac335
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit 02d5a67d39)
2020-02-20 08:35:45 +00:00
Yu Ping
ac267dd41b tls: need to use thread id to fetch the event
Type: fix

Change-Id: I429351f04a2865be4a289a3021277f9b2ced902b
Signed-off-by: Yu Ping <ping.yu@intel.com>
2020-02-20 01:40:53 +08:00
Florin Coras
96acc9b04a tcp: fix syn-sent reset
Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2799ac9723ec3e7effe910bba401fc486c552cac
2020-02-19 03:20:52 +00:00
Yu Ping
837826169f tls: handle disconect and reset in async mode
Type: fix

When async is enabled and request is inflight, delay close oepration

Change-Id: I713078fe9832c1599e8860fc0a6bb98588f20943
Signed-off-by: Yu Ping <ping.yu@intel.com>
2020-02-19 02:56:43 +00:00
Mohsin Kazmi
b9f1f15875 devices: netlink: add more error logging
Type: improvement

Change-Id: I4d8ca04840845e1ba631e4260e155df2486155e6
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
2020-02-18 22:57:52 +00:00
Florin Coras
7db5172ea2 misc: deprecating the plugin
Type: refactor

Not maintained

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I5568ecf1161b63cd0f314e2b1503e350e214e51b
2020-02-18 22:56:26 +00:00
Filip Tehlar
1307b2eb2c crypto: show crypto handlers re-design
Type: improvement

Show simple and chained handler details on a single line.

Change-Id: I5ad807a4d3608fc38c1134f564755d5751c30070
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2020-02-18 22:56:12 +00:00
Filip Tehlar
a9075dcf65 crypto: add support for testing quad loops in crypto algos
This patch adds support for test cases with arbitrary long plaintext.

Type: feature
Change-Id: I48cd3642e30cc49eabc196c45d7f73c484e93057
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2020-02-18 22:55:24 +00:00
Florin Coras
dd398c6c5c tcp: add fib to connection cli output
Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I3de653fd90b8030125b627f751c7fb665ade5aee
2020-02-18 22:54:21 +00:00
Filip Tehlar
2fc4091319 crypto: add chained buffer support in ipsecmb (AES-GCM)
Type: feature

Change-Id: Ia65caf38988c7e860e6d028f93659916825ef16b
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
2020-02-18 22:54:18 +00:00