Commit Graph

3098 Commits

Author SHA1 Message Date
Hongjun Ni ad2ddb1c06 Replace tap interface using general interface
Change-Id: Icd73f00162fb6aabe296c8bb6f2174ad4f6a17b7
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
2017-11-17 10:07:40 +00:00
Gabriel Ganne b8bbd6521f subunit is required on centos as well as fedora
Remove fedora dependency restriction on subunit and subunit-devel packages.
libsunit is only called in test/ext/Makefile on all platforms safe opensuse.

Change-Id: I483f42f20f6ba8bd112c18a9c51753a5d816d1c1
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
Signed-off-by: Romain Ly <romain.ly@enea.com>
2017-11-17 08:39:06 +00:00
Andrew Yourtchenko 9385aa096c acl-plugin: use ip.save_rewrite_length to calculate IP header offset on L3 egress path
L3 egress path does not set the ethernet flags reflecting the count of VLANs,
but rather has the offset explicitly, so use that.

Change-Id: Id3f6562dcd52ca24137c305f1a1c88c1f125da78
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2017-11-17 08:37:46 +00:00
Florin Coras dcf55ce28d vppcom: improve listener session handling
Change-Id: I86b2e2c5a655e53a915fbf62ff04ee23c86de234
Signed-off-by: Florin Coras <fcoras@cisco.com>
2017-11-17 04:50:59 +00:00
Andrew Yourtchenko aa0d62a9ad acl-plugin: also print human-friendly format of 5tuple in packet trace
The original version printed just a few u64s, which is useful for
directly working on the code, but not when figuring out what is
possibly a config or environment-related issue. So, add printing
the 5-tuple struct in a way that is usable by an operator.

Change-Id: I84cc3a239cdaff05ed31c3458cea198e38b58e03
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
2017-11-16 21:38:25 +00:00
Florin Coras 403642734c tcp: register with ip for header parsing by default
Change-Id: I4e420bcc9241b03e179a939911059c0cc3704a51
Signed-off-by: Florin Coras <fcoras@cisco.com>
2017-11-16 10:09:34 -08:00
Dave Barach 5292538534 Deal with double name-pointer chases
Change-Id: I153b07b4348133535b16b6bf55527d19a6b927c6
Signed-off-by: Dave Barach <dave@barachs.net>
2017-11-16 16:56:17 +00:00
Damjan Marion f11cbc4fc0 dpdk: add additional data to TX trace
Change-Id: I02b2b69db1e2afe62e3d3413034feb3bdcb3123e
Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-11-16 14:31:08 +00:00
Jakub Grajciar 8419755d4c libmemif: unmask head/tail pointers fix, additional ring info in memif_queue_details_t
Change-Id: I1dbf91c2a1575d5a82af70bfccdd990310323a8c
Signed-off-by: Jakub Grajciar <Jakub.Grajciar@pantheon.tech>
2017-11-16 14:22:46 +00:00
Sergio Gonzalez Monroy fbfe90ed4a dpdk/ipsec: use physmem when creating pools
Change-Id: Ic4f797cea6fa21fb29d646256210357cf5267b38
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
2017-11-16 13:49:20 +00:00
John Lo 70bfcaf477 Add Support of DHCP VSS Type 0 where VPN-ID is ASCII
Enhence support of DHCP VSS (Virtual Subnet Selection) to include
VSS type 0 where VSS info is a NVT (Network Virtual Terminal)
ASCII VPN ID where the ASCII string MUST NOT be terminated with a
zero byte. Existing code already support VSS type 1, where VSS
information is a RFC 2685 VPN-ID of 7 bytes with 3 bytes OUI
and 4 bytes VPN index, and VSS type 255 indicating global VPN.

Change-Id: I54edbc447c89a2aacd1cc9fc72bd5ba386037608
Signed-off-by: John Lo <loj@cisco.com>
2017-11-16 11:25:51 +00:00
Steven 9d72120a69 memif: fix uninitialized pointer read coverity error
Set the content of tmp.sock prior to calling memif_msg_send_disconnect.
Also fix the problem socket was not close in the same spot due to
error encountered.

Change-Id: I8f54ebad2250d1944afcc52e71d2a59da05362af
Signed-off-by: Steven <sluong@cisco.com>
2017-11-15 16:07:36 -08:00
Neale Ranns 93149bb4cd BIER: coverity fixes
Change-Id: I657bade082f9f754b294cd5f23ecfad4f0f46265
Signed-off-by: Neale Ranns <nranns@cisco.com>
2017-11-15 19:45:47 +00:00
Dave Barach b8a0d2cf9f Punt DNS request/reply traffic when name resolution disabled
Change-Id: Iaad22f25993783be57247aa1f050740f96d2566a
Signed-off-by: Dave Barach <dave@barachs.net>
2017-11-15 13:28:43 -05:00
Jakub Grajciar 5665a22f81 Revert "vnet: af_packet mark l3 offload cksum"
This reverts commit fa600c9169.

Change-Id: I873b53b2c025d7aba2211cab9b3e2d780af33b32
Signed-off-by: Jakub Grajciar <Jakub.Grajciar@pantheon.tech>
2017-11-15 18:19:59 +00:00
Gabriel Ganne 3904a0c72b vxlan extended tests - fix scapy-related issues
- Add vxlan-gpe binding on udp port 4790 (taken from scapy upstream)
- VXLAN.VNI -> VXLAN.vni

Change-Id: If7ad38fa04fbfec01e01c81a06e88ffe70183672
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
2017-11-15 15:43:11 +00:00
Gabriel Ganne eb9e6b6f07 add libffi-dev to DEB_DEPENDS
Package is already in the RPM_DEPENDS list, and is required for test-* targets

Change-Id: I3846e68855402b50a51adf3daf218e0244562cd6
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
2017-11-15 14:50:27 +00:00
Gabriel Ganne 9e12d7763d armv8 crc32 - fix macro name
Change-Id: Iba2d20c0a3d4f07457d108d014a6fa4522cb8e2c
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
2017-11-15 14:49:21 +00:00
Damjan Marion eecb26de2e Fix cosmetic issue in configure.ac
Change-Id: I0a6a58b4ed0a6609382cce8bc2c6668a681823fc
Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-11-15 14:46:31 +00:00
Neale Ranns 263f955e81 VOM: interface's handle() retreives from singular instance
Change-Id: I262f2113f5805c0f89b615a0383efa8520184dd1
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
2017-11-15 13:43:29 +00:00
Neale Ranns 352ea0c493 VOM: interface RD update reconfigures L3 bindings
Change-Id: I273e1ea28c3c146e4a88d031c790c1cc56dccf00
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
2017-11-15 10:38:29 +00:00
Neale Ranns 10e7a9f8d8 VOM: bridge-domain learning mode and route help commands
Change-Id: I2fa219d6530f1e7a3b8ae32d35a0c60ba57c5129
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
2017-11-14 19:25:54 +00:00
Neale Ranns a161a6dedb Ip6 dump not showing fib table names (VPP-1063)
Change-Id: Idc7e7c35f17d514589d1264f1d1be664192ee586
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
2017-11-14 19:25:46 +00:00
Damjan Marion bf024e65a1 Fix typos in configure.ac and dpdk/buffer.c
Change-Id: I74ff693315a3ffc7aa2640f25d906ca0d6da6bc5
Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-11-14 18:07:47 +00:00
Florin Coras 87bd96aa4d vppinfra: fix pool_get_aligned_will_expand for fixed pools
Change-Id: Ia66ac0a2fa23a3d29370b54e2014900838a8d3ac
Signed-off-by: Florin Coras <fcoras@cisco.com>
2017-11-14 16:53:31 +00:00
Gabriel Ganne 88fd504d79 NULL-terminate load_balance_nsh_nodes[]
Change-Id: Ibc5528bea564f6c2b0ff34220405395bc78274fc
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
2017-11-14 16:26:00 +00:00
Gabriel Ganne 0f8a96c084 bier - fix node table declaration
Need to be NULL-terminated.
Fix declarations of:
- bier_disp_table_bier_nodes
- bier_table_mpls_nodes
- bier_fmask_mpls_nodes

This was crashing during make test on aarch64 platform:
During the API call to bier_table_add_del, the crash happens during
dpo_default_get_next_node().

Change-Id: I16207ba38fc9ab65bad787878c4608740c312257
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
2017-11-14 16:25:35 +00:00
Florin Coras 156e5caeec Fix builtin http server static request free
Change-Id: Ice61d4c6c281aa8c4e89447208e0ad047bcce639
Signed-off-by: Florin Coras <fcoras@cisco.com>
2017-11-14 16:14:55 +00:00
Jakub Grajciar 64ae77890c vnet: af_packet_set_l4_cksum_offload device class check
Change-Id: Ie07b71977c46d2f1e030799a08cc5af0fdc397aa
Signed-off-by: Jakub Grajciar <Jakub.Grajciar@pantheon.tech>
2017-11-14 16:13:40 +00:00
Jakub Grajciar fa600c9169 vnet: af_packet mark l3 offload cksum
Change-Id: I42ee5898e1f775692811eebab11bcfe458f1ec63
Signed-off-by: Jakub Grajciar <Jakub.Grajciar@pantheon.tech>
2017-11-14 14:56:05 +01:00
Dave Wallace 227867f5d3 VCL-LDPRELOAD: add sendfile/sendfile64 implementation.
Change-Id: If0c399269238912456d670432d7e953c9d91b9fb
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2017-11-14 03:44:25 +00:00
Steve Shin 49806fe252 l2-flood: fix restore vnet buffer's flags in the replication routine
When BUM packets are flooded in the l2 domain, some data should be
kept and restored for recycling in the replication routine.
If l2 bridge domain has multiple interfaces mixed with normal and
vlan tagged, the vlan tag value of the vnet buffer can be changed
while flooding the replicated packets. The change is made to store
and restore the original vlan tag in the replication logic.

Change-Id: I399cf54cd2e74cb44a2be42241bdc4fba85032c5
Signed-off-by: Steve Shin <jonshin@cisco.com>
2017-11-14 03:08:50 +00:00
Damjan Marion 9324284af8 Reduce number of parallel builds
With recent introduction of C++ code required memory for each compiler
instance has significantly increased causing build issues.

Currently build system spins 2 compiler instances per logical CPU core.

As CPU can hardly execute more than one thread at a time, it should be
pretty safe to change that formula so it doesn't multiply number of cpu
cores by 2 and such change will signifucantly reduce amount of memory
needed.

Change-Id: Ic829fff6e45f4caf98a6d9c1c98c53ed003039ef
Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-11-13 20:09:23 +01:00
Damjan Marion 04f3db3847 dpdk: introduce AVX512 variants of node functions
Change-Id: If581feca0d51d0420c971801aecdf9250c671b36
Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-11-13 16:14:50 +00:00
Chris Luke 2d8bf30423 Instead of a min term size, use a default (VPP-1061)
- In the bug report, Docker was sometimes giving shells
  a 0,0 terminal size. The minimum-term-size logic meant
  that VPP assumed the terminal had 1 row. The pager
  functioned, but of course overwrote the one line with its
  own prompt.
- Instead of a minimum size, always use a default size when
  the either terminal dimension is 0.

Change-Id: Iee5a465f0e4cbb618ef2222b40a52994aefa54bf
Signed-off-by: Chris Luke <chrisy@flirble.org>
2017-11-13 14:33:32 +00:00
Ole Troan 192267d490 NAT: Buufer overflow for memcpy()
Change-Id: I11d1f9507d429ad8b25e9873272ede231623e622
Signed-off-by: Ole Troan <ot@cisco.com>
2017-11-13 08:14:37 +01:00
Dave Wallace de5fec943a session: add handle to disconnect_session_reply api msg.
Change-Id: I40f80110f5224b676d60252f9721fd1bc8a10b58
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2017-11-12 05:23:50 +00:00
Dave Wallace 3bd43b88ff VCL: clean up disconnect_session debug output.
- Run VPP in xfce4-terminal in VCL unit tests.

Change-Id: Iba6a870617a811261de0a54fa38cdb5109ae1d07
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2017-11-11 22:45:38 -05:00
Steven 0cdd5bd05b VCL/LDPRELOAD: Fix out-of-bounds access and inequality comparison coverity errors
Fixed out-of-bounds access in vcom_socket.c by limiting the copy to the
size of the address field that was passed. Truncation will occur if
the address field is not big enough.

Fixed inequality comparison in vppcom.c by using the predefined macro
MAP_FAILED.

Change-Id: I9517c29ae811d08058621bd548a352b4d4f05139
Signed-off-by: Steven <sluong@cisco.com>
2017-11-12 03:32:44 +00:00
Jon Loeliger b592ad758a ACL: Add coding-style-patch-verification and indent.
Change-Id: I2397ada9760d546423e031ad45535ef8801b05e7
Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-11-11 19:50:46 -06:00
Jon Loeliger 27cadd23b6 ACLs: Use better error return codes than "-1" everywhere.
Added two new errors:
    ACL_IN_USE_INBOUND
    ACL_IN_USE_OUTBOUND

Update ACL tests to expect new, precise return values.

Change-Id: I644861a18aa5b70cce5f451dd6655641160c7697
Signed-off-by: Jon Loeliger <jdl@netgate.com>
2017-11-11 19:06:46 +00:00
Neale Ranns 62fe07c8e3 MPLS disposition actions at the tail of unicast LSPs
Change-Id: I8c42e26152f2ed1246f91b789887bfc923418bdf
Signed-off-by: Neale Ranns <nranns@cisco.com>
2017-11-11 14:23:45 +00:00
Damjan Marion bfe470c04a Update CPU list
Change-Id: Ibee8973270366c38dced6eb3e8ca41784549183a
Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-11-11 02:28:10 +00:00
Damjan Marion c84a82c328 dpdk: optimize buffer alloc/free
This reverts commit 45a588fa3efaaf52360986360ab1f6827bae3164.

Change-Id: I7e541545791f7743ee827bdec8b6fc46cbb0938f
Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-11-11 01:16:42 +00:00
Damjan Marion ba3c77364c Handle CPU flags from autotools project
Change-Id: Id085c1e3cbc7bf03df02755f9e35896cdb57e9e3
Signed-off-by: Damjan Marion <damarion@cisco.com>
2017-11-11 00:18:25 +00:00
Dave Wallace 60caa064e5 VCL: Fix accept state machine, EPOLLET logic.
Change-Id: I909b717e5c62e91623483bdbb93d9fe4c14f0be7
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2017-11-10 23:39:46 +00:00
Brian Brooks a3eb63c585 Map SVM regions at a sane offset on arm64
Mapping shared virtual memory at 0x30000000, which appears to be derived
from x86-32, turns out to be too close to the heap on arm64 systems. The
symptoms of memory corruption were random and included crashes in the
Python runtime and what appeared to be corruption of malloc's internal
mutex. Thanks to Gabriel Ganne for pointing out that disabling ASLR seemed
to mitigate the situation.

This patch maps SVM regions at an offset from the arm64 kernel constant
TASK_UNMAPPED_BASE and also assumes a 48-bit VA (for Ubuntu).

Change-Id: I642e5fe83344ab9b5c66c93e0cf1575c17251f3b
Signed-off-by: Brian Brooks <brian.brooks@arm.com>
2017-11-10 22:26:10 +00:00
Dave Wallace 375e468da3 VCL-LDPRELOAD: Fix epoll_pwait timeout.
Change-Id: I5712f45c35dbdf34141c42b9d864cad1f918e5e8
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
2017-11-10 22:13:32 +00:00
Neale Ranns b8d4481a93 Break up vpe.api
- makes the VAPI generated file more consumable.
- VOM build times improve.

Change-Id: I838488930bd23a0d3818adfdffdbca3eead382df
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
2017-11-10 21:10:46 +00:00
Klement Sekera e178399942 make test: fix logic for CACHE_OUTPUT option
Change-Id: I9938c0154c860913e27cecb18ec68f247943a2e6
Signed-off-by: Klement Sekera <ksekera@cisco.com>
2017-11-10 20:29:15 +00:00