Commit Graph

5555 Commits

Author SHA1 Message Date
Damjan Marion
aed75f3d1d vppinfra: add simple ring implementation
Change-Id: I188e2dfd187d7b2ab7e0fbb11461f3db052f3224
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-12-28 23:31:51 +00:00
Florin Coras
5a2ec8fc41 session: free session after transport and app confirm
In addition to that, a bit of refactoring.

Change-Id: Iea1eabc2167bcdef185ec53bc09bae087c5398e6
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-28 20:41:44 +00:00
Florin Coras
fa915f8180 vcl: handle invalid sessions in epoll
Change-Id: I62d37f3c05451e5667863a2c6c551872d5dac1ea
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-28 20:41:31 +00:00
Paul Vinciguerra
fe4827c97d vpp_papi: MACAddress equals fails in unittest.
Before:
    EqualsAssertionError:  :: MACAddress(11:22:33:44:55:66) != MACAddress(11:22:33:44:55:66)
    ----------------------------------------------------------------------
    Ran 1 test in 0.002s
    FAILED (failures=1)
    MACAddress(11:22:33:44:55:66) != MACAddress(11:22:33:44:55:66)

After:

    ----------------------------------------------------------------------
    Ran 1 test in 0.001s
    OK

Change-Id: I89896a823b8f8a861813dabf23e7c9207e4fabb6
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2018-12-28 20:40:14 +00:00
Jon Loeliger
28eedf4e89 MAP: Install lpm.h as map.h references it.
Change-Id: I97c6475920b7f7028c2bb1117ff9e5f629a54b44
Signed-off-by: Jon Loeliger <jdl@netgate.com>
2018-12-27 20:05:22 +00:00
Florin Coras
223548d479 install-dep: force osleap boost dep install
Change-Id: I4a053f41eef138fc0e6db7e2650860c0ac999552
Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2018-12-27 10:15:16 -08:00
Florin Coras
d12ff50773 tcp: add more last-ack arcs
Change-Id: If538bb9d6fb489906099b727a7bfdb9d9af29402
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-26 15:54:01 +00:00
Florin Coras
85a3ddd4c8 tcp: separate active and passive establish timers
Change-Id: Ia2241e963cf45765d8d17c65eea781edbf74d4f9
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-26 15:45:27 +00:00
Damjan Marion
eb25abdfd8 avf: optimize RX function
Change-Id: Icd1e9638cdb288e94196391a2c85f2eaaf65387e
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-12-26 12:49:04 +01:00
Florin Coras
76bc13008c tcp: add fin-wait-1 dispatch arcs
Change-Id: Ie4cb08f5d9f7fd025f1a8ae610cebb0b0c315d9f
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-25 17:55:05 +00:00
Neale Ranns
420c6bf1a7 GBP: fix dump and VOM populate
Change-Id: I5440d80333190ebac46d22eac43183939805a24b
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-12-24 16:31:24 +00:00
Kingwel Xie
4270808205 crypto-input: bug fix check-op
fix a copy-paste bug, and a typo of function name

Change-Id: Ib408522d2bb6fde7a7492de6f5d5369b461d77c9
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
2018-12-24 15:45:10 +00:00
Neale Ranns
d482336380 FIB: adj src assert fix part 2
Change-Id: Ic112180e53a55993b06ba18102202d6ac5854def
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-12-24 15:03:53 +00:00
Florin Coras
3c514d5516 tcp: compute seq_end in tcp_input
syn/fin are no longer added to seq_end so they must be considered
individually in each state.

Change-Id: I5e3047194101c4fca2db9f9ad29a4a6468c397ab
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-24 11:04:48 +00:00
Damjan Marion
bde17bd6ef avf: optimize rx ring refill
Change-Id: Id35089d6c73b35cd25fd01e07966a2c7e2ea367e
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-12-23 18:12:45 +01:00
Neale Ranns
7b8f916688 FIB: remove assert from adj src
this is the case when the ADJ fib is in the non-forwarding trie

Change-Id: I7bcda475b3b1e142d16363147dba3a1e2c5a07f9
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-12-23 16:25:43 +00:00
Neale Ranns
d8cf40b8bb VOM: stats
- onnly read when connected. use bool for state
- operator<< for counter_t
- only publish stats for interfaces that have them available

Change-Id: I66a8a336a05912592851c88e3af69155d840a573
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-12-23 16:25:26 +00:00
Damjan Marion
e430b6ec12 avf: new ethernet-input support
Change-Id: I5511823f38ad56161b6a538f2d9e63459eded1eb
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-12-23 12:26:52 +01:00
Damjan Marion
c811663491 avf: add option to specify interface name
Change-Id: I94591d5b103280f8df157819d423fef7ee89d4c8
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-12-23 11:45:49 +01:00
Florin Coras
c227e4950d vcl: fix coverity warnings
Change-Id: I24445b08a46041c370094ebba4243422e2342a26
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-23 08:24:22 +00:00
Florin Coras
54ddf43533 tcp: improve waitclose in closing states
Change-Id: I90056176194cb2a144d49a3cb283653d8d30f051
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-22 10:34:45 -08:00
Damjan Marion
8d6f34e2b1 ethernet-input tagged packets optimizations
Change-Id: I21bdd8982d5f357590af8a2a0219bdebbaee4e74
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-12-22 16:33:16 +00:00
Damjan Marion
16d227aa14 dpdk: switch to in-memory mode, deprecate use of socket-mem
Change-Id: I3896bf9d71dc300520c53dbe3c2fd8fcd1470881
Signed-off-by: Damjan Marion <damarion@cisco.com>
2018-12-22 16:32:39 +00:00
Steven
27ca2982e1 tapv2: coverity woe
coverity complains about fd leaking inside the if statement because there is
a goto which bypasses the statement close (fd).

The fix is to close (fd) immediately after it is no longer used.

Change-Id: Ic5035b07ec1f179ff3db77744843e47aa8067a3c
Signed-off-by: Steven <sluong@cisco.com>
2018-12-22 11:50:40 +00:00
Kingwel Xie
b9894ee69f crypto-input impprovement:
1. multi-loop, and new style with vlib_buffer_enqueue_to_next
2. add error counter for AUTH-FAILURE
3. buffer trace changed. now it supports 'trace add dpdk-crypto-input 10'
   just like the other input nodes

Actual measurement shows >10 clocks per packets are saved, under QAT
or openssl PMD case

Change-Id: I6ea34e4ae3b08c381219ff6bc8adda2d927fbfd5
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
2018-12-22 11:50:14 +00:00
Florin Coras
66a1003f17 bapi/vat: fix socket transport for vat
Change-Id: I8e39df129f80c8d3d73181fc5d3ac60ae382a6b6
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-22 08:07:21 +00:00
Florin Coras
844a36d1a6 http server: improvements
- use http sessions to track communication with peer (as opposed to
using the raw sessions)
- for static server send ok message prior to sending data
- static server can now handle GET requests spread over multiple
packets. Good for testing http/tcp implementation.

Change-Id: I767a790de9a42e7087db5ce8eefd8efaf598c695
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-21 17:48:08 -08:00
Neale Ranns
1c17e2ecac GBP: add allowed ethertypes to contracts
Change-Id: I74782d3b9b71a071bb500c34866a017b8ee15767
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-12-21 18:12:25 +00:00
Jon Loeliger
fc7344f9be MAP: Convert from DPO to input feature.
Change-Id: I25c86aea23dff19656449b23133db27b1f062ac0
Signed-off-by: Jon Loeliger <jdl@netgate.com>
Signed-off-by: Ole Troan <ot@cisco.com>
2018-12-21 17:06:40 +00:00
Ole Troan
a45dc07c15 Revert "tests: Rework vpp config generation."
This reverts commit 919efad267.

Change-Id: I5ec4fa08a03f508dac684dc1ddbd7e6b85c49b97
Signed-off-by: Ole Troan <ot@cisco.com>
2018-12-21 16:14:15 +00:00
Neale Ranns
b7778b6310 MFIB: coverity fixes
Change-Id: I5c1bc498f7299e175070eb288e40f8d037c9be3a
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-12-21 15:59:08 +00:00
Matus Fabian
d2bad81b0d NAT: fix coverity error 190176 (VPP-1474)
Change-Id: I0ee80c7bec59d3e9c69e92e6cf0af1a6864a4ec4
Signed-off-by: Matus Fabian <matfabia@cisco.com>
2018-12-21 04:01:00 -08:00
Paul Vinciguerra
087c811b63 Python Tests: Make VppTestCase unit testable.
* This allows for VppTestCase to instantiated with an empty constructor.

Change-Id: Ib71d3bfb4529e113f9b73c39de9b95f12ee9cfb4
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2018-12-21 07:50:30 +00:00
Paul Vinciguerra
919efad267 tests: Rework vpp config generation.
* Allows test cases to configure the VPP runtime config
  during fixture setup.

* Sample use in a TestCase:
    @classmethod
    def setUpConstants(cls):
        tempdir = cls.tempdir
        cls.config.add('punt', 'socket', '%s/socket_punt' % cls.tempdir)
        super(TestPuntSocket, cls).setUpConstants()
        # enable/disabe a plugin via:
        #cls.config.add_plugin('dpdk_plugin.so', 'disable')

* Supports the following config stanzas:
	'unix',
        'acl-plugin'
        'api-queue'
        'api-trace'
        'api-segment'
        'cj'
        'cpu'
        'dns'
        'dpdk
        # currently don't support dynamic keys
        # 'heapsize'
        'l2learn'
        'l2tp'
        'mactime'
        'mc'
        'nat'
        'oam'
        'plugins'
        'punt'
        'session'
        'socksvr'
        'statseg'
        'tapcli'
        'tcp'
        'tuntap'
        'vhost-user'

Change-Id: I44f276487267d26eaa46f87e730bdd861003b234
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2018-12-21 07:49:37 +00:00
Ole Trøan
e21463d879 Revert "Build issue after https://gerrit.fd.io/r/#/c/16508/."
This reverts commit 57f170bdf9.

Change-Id: I1cab5be8b04ac881b712e67fd72ed202657fedf4
Signed-off-by: Ole Troan <ot@cisco.com>
2018-12-21 07:48:39 +00:00
Florin Coras
78cc4b0797 tcp: fix fin_wait_1 condition to send fin
Also add the closed-waiting session state wherein the session still
allows the transport to send oustanding data.

Change-Id: Ic47807379906ef2010934381ff0b9e53c7e631d8
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-21 04:19:20 +00:00
Neale Ranns
00a469d969 GBP: test case hardening against timing races
Change-Id: I3b5d369a37233c7bb2113ce31479371c610977ef
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-12-20 22:47:05 +00:00
Florin Coras
1af9ab58fc tcp: fix syn-sent reset
Change-Id: I4a811672b27c70bf0e9652c175c7f4168ec40ed7
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-20 10:32:41 -08:00
Matus Fabian
fd0d50879f NAT: total users and sessions gauges (VPP-1484)
Change-Id: I41a82e21571d5c64d01af72cd88c3983afac26ed
Signed-off-by: Matus Fabian <matfabia@cisco.com>
2018-12-20 15:12:11 +00:00
Neale Ranns
775f73c6ba FIB: encode the label stack in the FIB path during table dump
Change-Id: I28e8a99b980ad343a4209e673201791b91ceab4e
Signed-off-by: Neale Ranns <nranns@cisco.com>
2018-12-20 15:00:30 +00:00
Paul Vinciguerra
a3aaa61e2f test/vpp_ip.py: Correct usage of 'is'
* Correct 'is' (identity) usage where equality is needed '=='.
  * Change raise 'Exception' to log message and return NotImplemented.
    (see: https://docs.python.org/3/library/constants.html#NotImplemented)
  * Remove duplicate property: bytes.
  * Remove duplicate method: __eq__.

Change-Id: Id3ae4f92f985eb7cef334e2679f19ecc971007c1
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2018-12-20 12:44:59 +00:00
Paul Vinciguerra
852f5ef9cf VPP-1508 python3 tests: raw_input
'raw_input' does not exist in python3.

Change-Id: I95d916db2834fab83e5e791f35103a4513e610b8
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2018-12-20 12:44:26 +00:00
Paul Vinciguerra
defde0f870 Tests: Cleanup @skip decorator.
The runnning environment is static as of module load time,
so only evalute the conditions once at module load time.

Track-by: VPP-1518

Change-Id: I73b0d17ae1ff90789e70307f168d43921829aec8
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2018-12-20 12:43:38 +00:00
Paul Vinciguerra
57f170bdf9 Build issue after https://gerrit.fd.io/r/#/c/16508/.
CI passes without this.

Change-Id: Iba542211e7b7b0e43c87a293b63a320b511c3d40
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2018-12-20 10:06:36 +00:00
Paul Vinciguerra
fe820689cf Trivial: fix src/plugins/map/test.c memory leak
Change-Id: Iabc8bcddd1b30a3b14f3cfd13b3c0b77a63028d6
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
2018-12-20 09:30:35 +00:00
cohu
359db1e622 delete policer classify repeat count drop packets when action is DROP
Change-Id: Id912bc570f42b1709596a917ecf5e56c237ce192
Signed-off-by: cohu <cong.hu@tieto.com>
2018-12-20 09:23:52 +00:00
Klement Sekera
d0f70a346d reassembly: replace asserts with error counters
Change-Id: Iaa39aea990bc04147f6a049215e990a567d30106
Signed-off-by: Klement Sekera <ksekera@cisco.com>
2018-12-20 09:22:55 +00:00
Florin Coras
aefbedeb5d session: add cli option to dump session elog
Change-Id: I1f42644f143bb65ee764c0f869b402595126adac
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-19 23:42:09 -08:00
Florin Coras
5c0f166aa0 tcp: fix fin in syn-rcvd
Change-Id: Iba7c08c9edcf76ea24d00d5ea9e0586e9f94df4e
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-19 17:25:44 -08:00
Florin Coras
678a657ca4 tcp: add more state machine arcs
This mostly adds explicit drops or resets for state and flag
combinations that would've been otherwise dropped with a warning
message.

It also adds some valid RST handlers.

Change-Id: Ib0d19a0939fe275befeb29cf072b87b1a79937ce
Signed-off-by: Florin Coras <fcoras@cisco.com>
2018-12-19 13:51:38 -08:00