9ad423fceb
The current implmentation of the hash table is not thread-safe. This design leads to a segfault when VPP is handling a lot of tunnels for Wireguard, where one thread modifies the hash table and other threads start the lookup at the same time. This fix adds a barrier sync to the hash table access when Wireguard adds or deletes an element. Type: fix Signed-off-by: Gabriel Oginski <gabrielx.oginski@intel.com> Change-Id: Id460dfcd46ace17c7bdcd23bd9687d26cecf0a39
71 lines
1.7 KiB
C
71 lines
1.7 KiB
C
/*
|
|
* Copyright (c) 2020 Doc.ai and/or its affiliates.
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <vlib/vlib.h>
|
|
#include <vppinfra/hash.h>
|
|
#include <vppinfra/pool.h>
|
|
#include <vppinfra/random.h>
|
|
#include <wireguard/wireguard_index_table.h>
|
|
|
|
u32
|
|
wg_index_table_add (vlib_main_t *vm, wg_index_table_t *table,
|
|
u32 peer_pool_idx, u32 rnd_seed)
|
|
{
|
|
u32 key;
|
|
|
|
while (1)
|
|
{
|
|
key = random_u32 (&rnd_seed);
|
|
if (hash_get (table->hash, key))
|
|
continue;
|
|
|
|
vlib_worker_thread_barrier_sync (vm);
|
|
hash_set (table->hash, key, peer_pool_idx);
|
|
vlib_worker_thread_barrier_release (vm);
|
|
break;
|
|
}
|
|
return key;
|
|
}
|
|
|
|
void
|
|
wg_index_table_del (vlib_main_t *vm, wg_index_table_t *table, u32 key)
|
|
{
|
|
uword *p;
|
|
p = hash_get (table->hash, key);
|
|
if (p)
|
|
{
|
|
vlib_worker_thread_barrier_sync (vm);
|
|
hash_unset (table->hash, key);
|
|
vlib_worker_thread_barrier_release (vm);
|
|
}
|
|
}
|
|
|
|
u32 *
|
|
wg_index_table_lookup (const wg_index_table_t * table, u32 key)
|
|
{
|
|
uword *p;
|
|
|
|
p = hash_get (table->hash, key);
|
|
return (u32 *) p;
|
|
}
|
|
|
|
/*
|
|
* fd.io coding-style-patch-verification: ON
|
|
*
|
|
* Local Variables:
|
|
* eval: (c-set-style "gnu")
|
|
* End:
|
|
*/
|