BPF filter w/o optimization can take x2 - x3 more instructions, causing significant slow down in fast path. Enable pcap optimization by default via cli and introduce api v2 with pcap optimization control, keep v1 for a while as it exists in previous release already. Intriduce bpf filter cli dump, similar to tcpdump -d. Also fix memleak, function name typo, cli pcap format hint and add related tests. Type: improvement Signed-off-by: Vladislav Grishenko <themiron@yandex-team.ru> Change-Id: I92b2b519e92326f1b8e1a4dda6a3e3edc52f87ad
97 lines
2.7 KiB
C
97 lines
2.7 KiB
C
/*
|
|
*------------------------------------------------------------------
|
|
* Copyright (c) 2023 Cisco and/or its affiliates.
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*------------------------------------------------------------------
|
|
*/
|
|
|
|
#include <vlib/vlib.h>
|
|
#include <bpf_trace_filter/bpf_trace_filter.h>
|
|
#include <vlibapi/api.h>
|
|
#include <vlibmemory/api.h>
|
|
|
|
/* define message IDs */
|
|
#include <bpf_trace_filter/bpf_trace_filter.api_enum.h>
|
|
#include <bpf_trace_filter/bpf_trace_filter.api_types.h>
|
|
|
|
#define REPLY_MSG_ID_BASE (bm->msg_id_base)
|
|
#include <vlibapi/api_helper_macros.h>
|
|
|
|
static void
|
|
vl_api_bpf_trace_filter_set_t_handler (vl_api_bpf_trace_filter_set_t *mp)
|
|
{
|
|
bpf_trace_filter_main_t *bm = &bpf_trace_filter_main;
|
|
vl_api_bpf_trace_filter_set_reply_t *rmp;
|
|
clib_error_t *err = 0;
|
|
int rv = 0;
|
|
u8 is_del = !mp->is_add;
|
|
char *bpf_expr;
|
|
|
|
bpf_expr = vl_api_from_api_to_new_c_string (&mp->filter);
|
|
err = bpf_trace_filter_set_unset (bpf_expr, is_del, 0);
|
|
|
|
if (err)
|
|
{
|
|
rv = -1;
|
|
clib_error_report (err);
|
|
}
|
|
vec_free (bpf_expr);
|
|
|
|
REPLY_MACRO (VL_API_BPF_TRACE_FILTER_SET_REPLY);
|
|
}
|
|
|
|
static void
|
|
vl_api_bpf_trace_filter_set_v2_t_handler (vl_api_bpf_trace_filter_set_v2_t *mp)
|
|
{
|
|
bpf_trace_filter_main_t *bm = &bpf_trace_filter_main;
|
|
vl_api_bpf_trace_filter_set_v2_reply_t *rmp;
|
|
clib_error_t *err = 0;
|
|
int rv = 0;
|
|
u8 is_del = !mp->is_add;
|
|
u8 optimize = !!mp->optimize;
|
|
char *bpf_expr;
|
|
|
|
bpf_expr = vl_api_from_api_to_new_c_string (&mp->filter);
|
|
err = bpf_trace_filter_set_unset (bpf_expr, is_del, optimize);
|
|
|
|
if (err)
|
|
{
|
|
rv = -1;
|
|
clib_error_report (err);
|
|
}
|
|
vec_free (bpf_expr);
|
|
|
|
REPLY_MACRO (VL_API_BPF_TRACE_FILTER_SET_V2_REPLY);
|
|
}
|
|
|
|
#include <bpf_trace_filter/bpf_trace_filter.api.c>
|
|
|
|
static clib_error_t *
|
|
bpf_trace_filter_plugin_api_hookup (vlib_main_t *vm)
|
|
{
|
|
bpf_trace_filter_main_t *bm = &bpf_trace_filter_main;
|
|
|
|
/* ask for a correctly-sized block of API message decode slots */
|
|
bm->msg_id_base = setup_message_id_table ();
|
|
return 0;
|
|
}
|
|
|
|
VLIB_API_INIT_FUNCTION (bpf_trace_filter_plugin_api_hookup);
|
|
|
|
/*
|
|
* fd.io coding-style-patch-verification: ON
|
|
*
|
|
* Local Variables:
|
|
* eval: (c-set-style "gnu")
|
|
* End:
|
|
*/ |